[GitHub] asitstands commented on issue #10951: Fix broken cython build

[GitBox <gi...@apache.org>]

asitstands commented on issue #10951: Fix broken cython build
URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-392268944
 
 
   Now, it passed all tests under `tests/python` in my environment (python2 & python3, mkl, cuda, no mkldnn, no cudnn). There were three different problems in the cython module.
   
   1. `setup.py` is not compatible with cython 0.28. It is fixed.
   1. The shared library files generated by cython have symbols defined in libmxnet.so, but the dynamic linker failed to find `libmxnet.so` unless `LD_LIBRARY_PATH` is set to the installation directory. This caused import error at runtime but the default behavior of mxnet is to try cython first and fallback to ctypes silently if an import error is encountered. So users cannot catch the error unless they set `MXNET_ENFORCE_CYTHON` env variable. This PR provides default search paths for `libmxnet.so` via rpath so that the linker can find it without `LD_LIBRARY_PATH`.
   1. It looks like that the cython module for ndarray has been broken for months. It caused segfault due to the lack of a proper support of sparse arrays. This is also fixed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services