You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/17 20:47:33 UTC

[GitHub] [airflow] ferruzzi commented on a change in pull request #14251: Send region_name into parant class of AwsGlueJobHook

ferruzzi commented on a change in pull request #14251:
URL: https://github.com/apache/airflow/pull/14251#discussion_r577932116



##########
File path: airflow/providers/amazon/aws/hooks/glue.py
##########
@@ -74,6 +74,7 @@ def __init__(
         self.role_name = iam_role_name
         self.s3_glue_logs = 'logs/glue-logs/'
         kwargs['client_type'] = 'glue'
+        kwargs['region_name'] = region_name

Review comment:
       It looks like `../hooks/s3.py` and `glue.py` both extend `AwsBaseHook`, and `s3.py` passed it up to super() to handle the region_name assignment.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org