[jira] [Comment Edited] (FLINK-14740) Create OperatorID for OperatorMetricGroup which in batch job

["lining (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974160#comment-16974160 ] 

lining edited comment on FLINK-14740 at 11/14/19 11:28 AM:
-----------------------------------------------------------

Is it likely to guarantee that the name is unique? Even if the name is unique, when its length is too long, it will be intercepted, and it is necessary to ensure that the name after interception is unique. When using the REST API, is it possible to use the ID in the metric and whether to map the name to the ID.


was (Author: lining):
Is it difficult to guarantee that the name is unique? Even if the name is unique, when its length is too long, it will be intercepted, and it is necessary to ensure that the name after interception is unique. When using the REST API, is it possible to use the ID in the metric and whether to map the name to the ID.

> Create OperatorID for OperatorMetricGroup which in batch job 
> -------------------------------------------------------------
>
>                 Key: FLINK-14740
>                 URL: https://issues.apache.org/jira/browse/FLINK-14740
>             Project: Flink
>          Issue Type: Wish
>          Components: Runtime / Metrics
>            Reporter: lining
>            Priority: Major
>
> *In current design:*
> The DataSet job uses VertexID as the OperatorID in the OperatorMetricGroup (ps:TaskMetricGroup.getOrAddOperator (string name)).
> If two operators in the same vertex have the same name, they will overwrite each other in the TaskMetricGroup.
> *Proposal:*
> We could add the OperatorID to the operator of the dataset.
> {code:java}
> for (TaskInChain tic : this.chainedTasksInSequence) {
>    TaskConfig t = new TaskConfig(tic.getContainingVertex().getConfiguration());
>    Integer nodeId = tic.getPlanNode().getOptimizerNode().getId();
>    OperatorID operatorID = this.nodeId2OperatorId.get(nodeId);
>    if(operatorID == null) {
>       operatorID = new OperatorID();
>       this.nodeId2OperatorId.put(nodeId, operatorID);
>    }
>    t.addChainedTask(tic.getChainedTask(), tic.getTaskConfig(), tic.getTaskName(), operatorID.toString());
> }
> {code}
> Then we could get id from TaskInfo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)