You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/10/02 15:49:38 UTC

[Bug 58472] New: parameter type change in TextRun.setFontSize()

https://bz.apache.org/bugzilla/show_bug.cgi?id=58472

            Bug ID: 58472
           Summary: parameter type change in TextRun.setFontSize()
           Product: POI
           Version: 3.13-dev
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: XSLF
          Assignee: dev@poi.apache.org
          Reporter: Mark.Olesen@gmx.net

XSLFTextRun.setFontSize() now expects a Double (was double).
This prevents promotion from int, which seems to be an unneeded break in
functionality. Why not retain the unboxed primitives?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58472] parameter type change in TextRun.setFontSize()

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58472

--- Comment #3 from mark.o <Ma...@gmx.net> ---
> "font size in points, if null the underlying fontsize will be unset"
> setting the value to null will force the usage of the slidelayout value.

OK - this is now quite clear. Thanks for the explanation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58472] parameter type change in TextRun.setFontSize()

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58472

mark.o <Ma...@gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from mark.o <Ma...@gmx.net> ---
Note:
SL : [sg]etFontSize uses Double
SS : [sg]etFontSize uses double
WP : [sg]etFontSize uses int

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58472] parameter type change in TextRun.setFontSize()

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58472

mark.o <Ma...@gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58472] parameter type change in TextRun.setFontSize()

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58472

Andreas Beeker <ki...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #2 from Andreas Beeker <ki...@apache.org> ---
Lets start with the javadocs for this function:
"font size in points, if null the underlying fontsize will be unset"

> This prevents promotion from int ...
... but fontsizes can be also specified as real numbers

> Why not retain the unboxed primitives?
setting the value to null will force the usage of the slidelayout value.
Even worse is using something as -1 as indicator for unset values.

Currently I haven't applied this logic to all methods.
Whenever something is promoted to common sl, I'll adapt the handling in X/HSLF 
accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org