You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/09/29 20:45:09 UTC

[GitHub] [hbase] Apache-HBase commented on issue #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible

Apache-HBase commented on issue #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible
URL: https://github.com/apache/hbase/pull/673#issuecomment-536339538
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | :blue_heart: |  reexec  |   1m  9s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 5 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | :blue_heart: |  mvndep  |   1m  3s |  Maven dependency ordering for branch  |
   | :green_heart: |  mvninstall  |   5m 50s |  master passed  |
   | :green_heart: |  compile  |   1m 46s |  master passed  |
   | :green_heart: |  checkstyle  |   2m 20s |  master passed  |
   | :green_heart: |  shadedjars  |   4m 59s |  branch has no errors when building our shaded downstream artifacts.  |
   | :green_heart: |  javadoc  |   1m 16s |  master passed  |
   | :blue_heart: |  spotbugs  |   4m 18s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | :green_heart: |  findbugs  |   6m  6s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | :blue_heart: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | :green_heart: |  mvninstall  |   5m 30s |  the patch passed  |
   | :green_heart: |  compile  |   1m 45s |  the patch passed  |
   | :green_heart: |  javac  |   1m 45s |  the patch passed  |
   | :broken_heart: |  checkstyle  |   0m 33s |  hbase-client: The patch generated 4 new + 38 unchanged - 1 fixed = 42 total (was 39)  |
   | :broken_heart: |  checkstyle  |   1m 33s |  hbase-server: The patch generated 4 new + 258 unchanged - 0 fixed = 262 total (was 258)  |
   | :broken_heart: |  checkstyle  |   0m 13s |  hbase-examples: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | :green_heart: |  shadedjars  |   5m  2s |  patch has no errors when building our shaded downstream artifacts.  |
   | :green_heart: |  hadoopcheck  |  17m 12s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | :green_heart: |  javadoc  |   1m 14s |  the patch passed  |
   | :green_heart: |  findbugs  |   6m 39s |  the patch passed  |
   ||| _ Other Tests _ |
   | :green_heart: |  unit  |   1m 49s |  hbase-client in the patch passed.  |
   | :broken_heart: |  unit  | 287m 12s |  hbase-server in the patch failed.  |
   | :green_heart: |  unit  |   2m  4s |  hbase-examples in the patch passed.  |
   | :green_heart: |  asflicense  |   1m 18s |  The patch does not generate ASF License warnings.  |
   |  |   | 364m 10s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/673 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 79b0696572aa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-673/out/precommit/personality/provided.sh |
   | git revision | master / 1170f28122 |
   | Default Java | 1.8.0_181 |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/1/artifact/out/diff-checkstyle-hbase-client.txt |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/1/artifact/out/diff-checkstyle-hbase-server.txt |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/1/artifact/out/diff-checkstyle-hbase-examples.txt |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/1/artifact/out/patch-unit-hbase-server.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/1/testReport/ |
   | Max. process+thread count | 4825 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-server hbase-examples U: . |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services