[GitHub] nifi issue #969: NIFI-2629 - Hide add property "+" in Processors, Controller...

[markap14 <gi...@git.apache.org>]

Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/969
  
    @kirkalicious thanks for the PR! The concerning thing here is that we need to make sure that any Processor, Controller Service, Reporting task that does support dynamic properties actually has the @DynamicProperty annotation. The annotation was placed in the 'org.apache.nifi.annotation.behavior' package instead of 'org.apache.nifi.annotation.documentation' package, I believe, so that we can do this sort of thing.
    
    However, thus far, we have not enforced it, and we need to ensure that we do not break backward compatibility. Doing a quick search of the codebase for "getSupportedDynamicPropertyDescriptor" shows that there are at least a couple of processors that do not have the @DynamicProperty annotation that should. At a minimum, we should address those.
    
    I do have some hesitation, though, that this could potentially break custom processors in the same way, by no longer allowing users to add their own properties.
    
    @joewitt @mcgilman or any others have any thoughts on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---