[incubator-openwhisk] branch master updated: Lower minimum number of available file descriptors in action limit tests (#4553)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markusthoemmes pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-openwhisk.git


The following commit(s) were added to refs/heads/master by this push:
     new 9c428a3  Lower minimum number of available file descriptors in action limit tests (#4553)
9c428a3 is described below

commit 9c428a3fbf50ff0af5f18f5f1bd2816efd8c479a
Author: Sven Lange-Last <sv...@de.ibm.com>
AuthorDate: Wed Jul 10 16:33:13 2019 +0200

    Lower minimum number of available file descriptors in action limit tests (#4553)
---
 .../org/apache/openwhisk/core/limits/ActionLimitsTests.scala  | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tests/src/test/scala/org/apache/openwhisk/core/limits/ActionLimitsTests.scala b/tests/src/test/scala/org/apache/openwhisk/core/limits/ActionLimitsTests.scala
index 62d3508..c317373 100644
--- a/tests/src/test/scala/org/apache/openwhisk/core/limits/ActionLimitsTests.scala
+++ b/tests/src/test/scala/org/apache/openwhisk/core/limits/ActionLimitsTests.scala
@@ -66,7 +66,16 @@ class ActionLimitsTests extends TestHelpers with WskTestHelpers with WskActorSys
 
   val openFileAction = TestUtils.getTestActionFilename("openFiles.js")
   val openFileLimit = 1024
-  val minExpectedOpenFiles = openFileLimit - 20 // allow for already opened files in container
+  // Allow for already opened files in container.
+  // Attention: do not change this value without a thorough check. It ensures that
+  // OpenWhisk users have a minimum number of file descriptors available in their actions.
+  // If changes in a managed runtime lead to a decrease of file descriptors available for
+  // action code, this may break existing actions.
+  // Examples:
+  // * With the introduction of Node.js 10, this was changed from "openFileLimit - 15" to
+  //   "openFileLimit - 20".
+  // * With Docker 18.09.3, we observed test failures and changed to "openFileLimit - 24".
+  val minExpectedOpenFiles = openFileLimit - 24
 
   behavior of "Action limits"