You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/22 16:25:49 UTC
[GitHub] [flink] zentol opened a new pull request, #20053: [FLINK-28201][ci] Generalize utils around dependency plugin
zentol opened a new pull request, #20053:
URL: https://github.com/apache/flink/pull/20053
This PR reworks the parsing of the output from the dependency-plugin to make it more generic and re-usable for other checks.
The scala suffix checker, the only current user, was migrated as part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20053: [FLINK-28201][ci] Generalize utils around dependency plugin
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20053:
URL: https://github.com/apache/flink/pull/20053#issuecomment-1163342659
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "50da2a67713f98edca34821b185a68254a41efb8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "50da2a67713f98edca34821b185a68254a41efb8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50da2a67713f98edca34821b185a68254a41efb8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #20053: [FLINK-28201][ci] Generalize utils around dependency plugin
Posted by GitBox <gi...@apache.org>.
zentol merged PR #20053:
URL: https://github.com/apache/flink/pull/20053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #20053: [FLINK-28201][ci] Generalize utils around dependency plugin
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20053:
URL: https://github.com/apache/flink/pull/20053#discussion_r903987642
##########
tools/ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/suffixcheck/ScalaSuffixChecker.java:
##########
@@ -96,40 +98,35 @@ private static ParseResult parseMavenOutput(final Path path) throws IOException
final Set<String> cleanModules = new HashSet<>();
final Set<String> infectedModules = new HashSet<>();
- try (final BufferedReader bufferedReader =
- Files.newBufferedReader(path, StandardCharsets.UTF_8)) {
+ final Map<String, Set<Dependency>> dependenciesByModule =
+ DependencyParser.parseDependencyTree(path);
- String line;
- while ((line = bufferedReader.readLine()) != null) {
- final Matcher matcher = moduleNamePattern.matcher(line);
- if (matcher.matches()) {
- final String moduleName = stripScalaSuffix(matcher.group(1));
+ for (String module : dependenciesByModule.keySet()) {
+ final String moduleName = stripScalaSuffix(module);
+ {
+ {
Review Comment:
These are only here to make the review easier (keeping the indentation levels the same), and are removed in the second commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #20053: [FLINK-28201][ci] Generalize utils around dependency plugin
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20053:
URL: https://github.com/apache/flink/pull/20053#issuecomment-1177606268
Reviewd in #20067.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org