You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-cvs@httpd.apache.org by nd...@apache.org on 2003/11/01 18:28:48 UTC

cvs commit: httpd-test/perl-framework/t/modules include.t

nd          2003/11/01 09:28:48

  Modified:    perl-framework/t/modules include.t
  Log:
  disable the fsize/flastmod-test for now, until there's a better solution
  
  Revision  Changes    Path
  1.41      +5 -2      httpd-test/perl-framework/t/modules/include.t
  
  Index: include.t
  ===================================================================
  RCS file: /home/cvs/httpd-test/perl-framework/t/modules/include.t,v
  retrieving revision 1.40
  retrieving revision 1.41
  diff -u -u -r1.40 -r1.41
  --- include.t	29 Aug 2003 00:05:32 -0000	1.40
  +++ include.t	1 Nov 2003 17:28:48 -0000	1.41
  @@ -108,12 +108,12 @@
   );
   
   #
  -# in addition to $tests, there are 1 fsize/flastmod test, 1 GET test,
  +# in addition to $tests, there are 0 fsize/flastmod test, 1 GET test,
   # 11 XBitHack tests, 2 exec cgi tests, 2 malformed-ssi-directive tests,
   # and 14 tests that use mod_bucketeer to construct brigades for mod_include
   #
   my $tests = scalar(keys %test) + scalar(keys %t_test) + @patterns + 2;
  -plan tests => $tests + 31, have_module 'include';
  +plan tests => $tests + 30, have_module 'include';
   
   Apache::TestRequest::scheme('http'); #ssl not listening on this vhost
   Apache::TestRequest::module('mod_include'); #use this module's port
  @@ -158,6 +158,8 @@
           );
   
   ### FLASTMOD/FSIZE TESTS
  +### disabled for now, until there's a better solution.
  +my $todo = sub {
   unless(eval{require POSIX}) {
       skip "POSIX module not found", 1;
   }
  @@ -203,6 +205,7 @@
                "GET ${dir}file.shtml"
               );
   }
  +}; # /todo
   
   ### EXEC CGI TESTS
   # skipped if !have_cgi
  
  
  

Re: cvs commit: httpd-test/perl-framework/t/modules include.t

Posted by André Malo <nd...@perlig.de>.
* Stas Bekman <st...@stason.org> wrote:

> BTW, there is a much simpler way to turn tests into todos without touching
> the sub-test's code:
> http://perl.apache.org/docs/general/testing/testing.html#Todo_Sub_tests

Oh well, I knew there was something ... :-) I'll fix it.

nd

Re: cvs commit: httpd-test/perl-framework/t/modules include.t

Posted by Stas Bekman <st...@stason.org>.
nd@apache.org wrote:
> nd          2003/11/01 09:28:48
> 
>   Modified:    perl-framework/t/modules include.t
>   Log:
>   disable the fsize/flastmod-test for now, until there's a better solution

BTW, there is a much simpler way to turn tests into todos without touching the 
sub-test's code:
http://perl.apache.org/docs/general/testing/testing.html#Todo_Sub_tests
[...]
>    my $tests = scalar(keys %test) + scalar(keys %t_test) + @patterns + 2;
>   -plan tests => $tests + 31, have_module 'include';
>   +plan tests => $tests + 30, have_module 'include';
>    
>    Apache::TestRequest::scheme('http'); #ssl not listening on this vhost
>    Apache::TestRequest::module('mod_include'); #use this module's port
>   @@ -158,6 +158,8 @@
>            );
>    
>    ### FLASTMOD/FSIZE TESTS
>   +### disabled for now, until there's a better solution.
>   +my $todo = sub {
>    unless(eval{require POSIX}) {
>        skip "POSIX module not found", 1;
>    }
>   @@ -203,6 +205,7 @@
>                 "GET ${dir}file.shtml"
>                );
>    }
>   +}; # /todo



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Re: cvs commit: httpd-test/perl-framework/t/modules include.t

Posted by Geoffrey Young <ge...@modperlcookbook.org>.

André Malo wrote:
> * Geoffrey Young <ge...@modperlcookbook.org> wrote:
> 
> 
>>if you're working on mod_include stuff at the moment, I wanted to re-mention
>>an issue with the ETag header, in case you missed it and have the time to
>>evaluate it now.
>>
>>http://marc.theaimsgroup.com/?l=apache-test-dev&m=106261842526075&w=2
> 
> 
> Thanks for reminder. Actually I've missed the issue and fixed it now.

cool.  I caught your comments on bugzilla as well.  thanks for following up.

--Geoff


Re: cvs commit: httpd-test/perl-framework/t/modules include.t

Posted by André Malo <nd...@perlig.de>.
* Geoffrey Young <ge...@modperlcookbook.org> wrote:

> if you're working on mod_include stuff at the moment, I wanted to re-mention
> an issue with the ETag header, in case you missed it and have the time to
> evaluate it now.
> 
> http://marc.theaimsgroup.com/?l=apache-test-dev&m=106261842526075&w=2

Thanks for reminder. Actually I've missed the issue and fixed it now.

nd

Re: cvs commit: httpd-test/perl-framework/t/modules include.t

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
hi andre

if you're working on mod_include stuff at the moment, I wanted to re-mention 
an issue with the ETag header, in case you missed it and have the time to 
evaluate it now.

http://marc.theaimsgroup.com/?l=apache-test-dev&m=106261842526075&w=2

--Geoff