[GitHub] [spark] maropu commented on a change in pull request #27835: Revert "[SPARK-25457][SQL] IntegralDivide returns data type of the operands"

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #27835: Revert "[SPARK-25457][SQL] IntegralDivide returns data type of the operands"
URL: https://github.com/apache/spark/pull/27835#discussion_r388912063
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/operators.sql
 ##########
 @@ -22,6 +22,16 @@ select 5 / 0;
 select 5 / null;
 select null / 5;
 
+-- integral div
+select 5 div 2;
+select 5 div 0;
+select 5 div null;
+select null div 5;
+select cast(51 as decimal(10, 0)) div cast(2 as decimal(2, 0));
+select cast(5 as decimal(1, 0)) div cast(0 as decimal(2, 0));
+select cast(5 as decimal(1, 0)) div cast(null as decimal(2, 0));
+select cast(null as decimal(1, 0)) div cast(5 as decimal(2, 0));
 
 Review comment:
   Were the four tests above newly added in this pr?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org