You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/28 13:00:37 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5635: fs/romfs: optimize romfs_open speed and get path by cmd FIOC_FILEPATH

acassis commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-nuttx/pull/5635#discussion_r815865145



##########
File path: fs/romfs/Kconfig
##########
@@ -11,4 +11,13 @@ config FS_ROMFS
 		Enable ROMFS filesystem support
 
 if FS_ROMFS
+
+config FS_ROMFS_CACHE_NODE
+	bool "Enable cache node of ROMFS file system"
+	default n

Review comment:
       Maybe it could be default y if !CONFIG_DEFAULT_SMALL. I think if a feature brings benefit to users (like speed/performance) it could be enabled by default. Otherwise we are creating many useful features that many people don't know that exist (he/she will need to search high and low the menuconfig to discover it).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org