You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/28 19:19:55 UTC
[GitHub] [flink] piyushnarang opened a new pull request #11938: [FLINK-17443] [runtime] Flink's ZK in HA mode setup is unable to start up if any of the zk hosts are unreachable
piyushnarang opened a new pull request #11938:
URL: https://github.com/apache/flink/pull/11938
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Flink clusters using zookeeper in HA will not startup if any of the zookeeper hosts passed in the "high-availability.zookeeper.quorum" config setting are unreachable (even if the others are).
Sample error:
```
java.net.UnknownHostException: foo-host: Name or service not known
at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:929)
at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1324)
at java.net.InetAddress.getAllByName0(InetAddress.java:1277)
at java.net.InetAddress.getAllByName(InetAddress.java:1193)
at java.net.InetAddress.getAllByName(InetAddress.java:1127)
at org.apache.flink.shaded.zookeeper.org.apache.zookeeper.client.StaticHostProvider.<init>(StaticHostProvider.java:61)
at org.apache.flink.shaded.zookeeper.org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:445)
at org.apache.flink.shaded.curator.org.apache.curator.utils.DefaultZookeeperFactory.newZooKeeper(DefaultZookeeperFactory.java:29)
at org.apache.flink.shaded.curator.org.apache.curator.framework.imps.CuratorFrameworkImpl$2.newZooKeeper(CuratorFrameworkImpl.java:150)
at org.apache.flink.shaded.curator.org.apache.curator.HandleHolder$1.getZooKeeper(HandleHolder.java:94)
at org.apache.flink.shaded.curator.org.apache.curator.HandleHolder.getZooKeeper(HandleHolder.java:55)
at org.apache.flink.shaded.curator.org.apache.curator.ConnectionState.reset(ConnectionState.java:262)
at org.apache.flink.shaded.curator.org.apache.curator.ConnectionState.start(ConnectionState.java:109)
at org.apache.flink.shaded.curator.org.apache.curator.CuratorZookeeperClient.start(CuratorZookeeperClient.java:191)
at org.apache.flink.shaded.curator.org.apache.curator.framework.imps.CuratorFrameworkImpl.start(CuratorFrameworkImpl.java:259)
at org.apache.flink.runtime.util.ZooKeeperUtils.startCuratorFramework(ZooKeeperUtils.java:131)
at org.apache.flink.runtime.highavailability.HighAvailabilityServicesUtils.createHighAvailabilityServices(HighAvailabilityServicesUtils.java:123)
at org.apache.flink.runtime.entrypoint.ClusterEntrypoint.createHaServices(ClusterEntrypoint.java:292)
at org.apache.flink.runtime.entrypoint.ClusterEntrypoint.initializeServices(ClusterEntrypoint.java:257)
```
This error seems to stem from us being on an older zookeeper release (3.4.10). This has been fixed as part of: https://issues.apache.org/jira/browse/ZOOKEEPER-1576 in the 3.4.x branch (https://github.com/apache/zookeeper/commit/be1409cc9a14ac2e28693e0e02a0ba6d9713565e). This change updates our zookeeper dependency to 3.4.14 to pull this fix in.
## Brief change log
* Flink's ZK in HA mode setup is unable to start up if any of the zk hosts are unreachable
## Verifying this change
I manually tested this by invoking the Zookeeper StaticHostProvider class with an invalid host. I've not added an explicit test in Flink as it is covered in the ZK project.
```
@Test
public void testStaticHostProviderIssue() throws Exception {
// first host is invalid
String quorum = "zk666-pa4.hpc.criteo.prod:2181,zk02-pa4.hpc.criteo.prod:2181";
ConnectStringParser connectStringParser = new ConnectStringParser(quorum);
HostProvider hostProvider = new StaticHostProvider(connectStringParser.getServerAddresses());
hostProvider.next(10); // next triggers the resolve in the new zk version
hostProvider.next(10);
hostProvider.next(10);
}
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #11938: [FLINK-17443] [runtime] Flink's ZK in HA mode setup is unable to start up if any of the zk hosts are unreachable
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #11938:
URL: https://github.com/apache/flink/pull/11938#issuecomment-621163697
It unfortunately isn't this simple to bump the zookeeper dependency; please have a look at my latest comment in the JIRA.
I will close the PR for the time being as we first have to go through some other steps beforehand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11938: [FLINK-17443] [runtime] Flink's ZK in HA mode setup is unable to start up if any of the zk hosts are unreachable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11938:
URL: https://github.com/apache/flink/pull/11938#issuecomment-620811383
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2fea9756d8fb55177619e3bf14c19d53d4612148",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=385",
"triggerID" : "2fea9756d8fb55177619e3bf14c19d53d4612148",
"triggerType" : "PUSH"
}, {
"hash" : "2fea9756d8fb55177619e3bf14c19d53d4612148",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162514886",
"triggerID" : "2fea9756d8fb55177619e3bf14c19d53d4612148",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2fea9756d8fb55177619e3bf14c19d53d4612148 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162514886) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=385)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11938: [FLINK-17443] [runtime] Flink's ZK in HA mode setup is unable to start up if any of the zk hosts are unreachable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11938:
URL: https://github.com/apache/flink/pull/11938#issuecomment-620811383
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2fea9756d8fb55177619e3bf14c19d53d4612148",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2fea9756d8fb55177619e3bf14c19d53d4612148",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2fea9756d8fb55177619e3bf14c19d53d4612148 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11938: [FLINK-17443] [runtime] Flink's ZK in HA mode setup is unable to start up if any of the zk hosts are unreachable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11938:
URL: https://github.com/apache/flink/pull/11938#issuecomment-620805908
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2fea9756d8fb55177619e3bf14c19d53d4612148 (Tue Apr 28 19:22:19 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17443).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org