You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Steve Lawrence (Jira)" <ji...@apache.org> on 2021/08/12 13:45:00 UTC

[jira] [Commented] (DAFFODIL-1663) Does not detect very long dfdl:format ref="super long thing here more than 1000 chars"

    [ https://issues.apache.org/jira/browse/DAFFODIL-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398073#comment-17398073 ] 

Steve Lawrence commented on DAFFODIL-1663:
------------------------------------------

I think this bug need a bit more explanation about what is going on, and the expected behavior. Here's what I'm thinking:

The schema in these tests compiles and parses data and creates an infoset, even with a huge ~5200 character namespace prefix. So at first it seems like this is the correct behavior.

However, based on the expected results in the TDML tests, we are expecting an error that is something like "length of entity exceeds limit". So it looks like we are expecting very long namespaces to fail, which it currently does not.

Searching for this expected error message, I came across this: [https://userapps.support.sap.com/sap/support/knowledge/en/2663241]

Which says to me that if we enable FEATURE_SECURE_PROCESSING, then limits should be enforced and then this test should pass. But, we already do enable this feature. So either:
 # There's a bug somewhere and we aren't actually enabling this feature when compiling schemas
 # This feature is correctly enabled, but it just doesn't limit the length of entiies at all
 # This features is correctly enabled, and it does limit the length of entities, that limit is just larger than what our test uses

I can't seem to find a good reference for what limits FEATURE_SECURE_PROCESSING actually imposes, but I can find some reference that imply it's much larger than the 5200 that our test uses.

> Does not detect very long dfdl:format ref="super long thing here more than 1000 chars"
> --------------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-1663
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-1663
>             Project: Daffodil
>          Issue Type: Bug
>          Components: API, Front End
>    Affects Versions: 2.0.0
>            Reporter: Mike Beckerle
>            Priority: Minor
>
> test_namespaceLimitParse
>  test_namespaceLimitUnparse
> moved to scala debug. Both these these tests use a schema which has 
> {code}
> <dfdl:format ref="...." .../>
> {code}
> But this is not detected even if the length is well over 1000 characters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)