You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by Brock Noland <br...@cloudera.com> on 2013/01/05 20:26:20 UTC
Re: [DISCUSS] creating seperate branches for hadoop 1 and hadoop 2
Alright, I am back from vacation. I will go ahead and do this branch today.
On Tue, Dec 25, 2012 at 9:49 AM, Brock Noland <br...@cloudera.com> wrote:
> OK sounds like we are all in agreement here.
>
>
> On Fri, Dec 21, 2012 at 3:59 PM, Patrick Hunt <ph...@apache.org> wrote:
>> As long as you can be explicit about what's in the release I think you're good.
>>
>> Patrick
>>
>> On Fri, Dec 21, 2012 at 1:41 PM, Brock Noland <br...@cloudera.com> wrote:
>>> I don't see anything in the release FAQ
>>> (http://www.apache.org/dev/release.html) about releasing two different
>>> tags at the same time. As such I assume when releasing we could
>>> include two tags as part of a single release.
>>>
>>> Brock
>>>
>>> On Fri, Dec 21, 2012 at 3:02 PM, Dave Beech <da...@paraliatech.com> wrote:
>>>> I've almost suggested the same thing while looking at a couple of the
>>>> issues Patrick has raised. Too much has changed / is still changing between
>>>> the hadoop 1 and 2 APIs. It's pretty much impossible already to cater to
>>>> both and I don't see the situation improving. We already produce 2
>>>> artifacts, so we might as well produce them from different branches. The
>>>> end result for the user will be no different.
>>>>
>>>> Big +1 from me.
>>>>
>>>> Cheers
>>>> Dave
>>>>
>>>>
>>>> On 21 December 2012 19:40, Jarek Jarcec Cecho <ja...@apache.org> wrote:
>>>>
>>>>> We had recently similar incompatibility fight in Sqoop, so I can
>>>>> understand your frustration.
>>>>>
>>>>> I'm +1 on the proposal.
>>>>>
>>>>> Jarcec
>>>>>
>>>>> On Fri, Dec 21, 2012 at 01:29:19PM -0600, Brock Noland wrote:
>>>>> > Hi,
>>>>> >
>>>>> > In MRUNIT-31 we used mockito to allow a single branch of code work
>>>>> > with hadoop 1 and hadoop 2. Patrick Hunt has filed a number of tickets
>>>>> > for items which don't work with hadoop 2. I do not see an easy way to
>>>>> > fix MRUNIT-167 and MRUNIT-161 in a single branch since hadoop 1 is
>>>>> > lacking a large number of methods that hadoop 2 supports.
>>>>> >
>>>>> > As such, I think that we should think about the following:
>>>>> >
>>>>> > 1) Create hadoop-1 to support hadoop 1 with trunk supporting hadoop 2.
>>>>> > 2) Resolve MRUNIT-167 and MRUNIT-161 in trunk.
>>>>> > 3) Going forward we will have to backport from trunk to the hadoop-1
>>>>> > branch. At first this will be simple since they are so similar. Over
>>>>> > time this will become more difficult. Hopefully by the time it's too
>>>>> > difficult to support hadoop-1 most people will have already moved to
>>>>> > hadoop 2.
>>>>> > 4) During releases we'll have to generate artifacts from both branches.
>>>>> >
>>>>> > Thoughts?
>>>>> >
>>>>> > --
>>>>> > Apache MRUnit - Unit testing MapReduce -
>>>>> http://incubator.apache.org/mrunit/
>>>>>
>>>
>>>
>>>
>>> --
>>> Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
>
>
>
> --
> Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
--
Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
Re: [DISCUSS] creating seperate branches for hadoop 1 and hadoop 2
Posted by Brock Noland <br...@cloudera.com>.
OK this done. We still have some work to figure out the pom.xml
changes which can be tracked here
https://issues.apache.org/jira/browse/MRUNIT-170
Brock
On Sat, Jan 5, 2013 at 1:26 PM, Brock Noland <br...@cloudera.com> wrote:
> Alright, I am back from vacation. I will go ahead and do this branch today.
>
> On Tue, Dec 25, 2012 at 9:49 AM, Brock Noland <br...@cloudera.com> wrote:
>> OK sounds like we are all in agreement here.
>>
>>
>> On Fri, Dec 21, 2012 at 3:59 PM, Patrick Hunt <ph...@apache.org> wrote:
>>> As long as you can be explicit about what's in the release I think you're good.
>>>
>>> Patrick
>>>
>>> On Fri, Dec 21, 2012 at 1:41 PM, Brock Noland <br...@cloudera.com> wrote:
>>>> I don't see anything in the release FAQ
>>>> (http://www.apache.org/dev/release.html) about releasing two different
>>>> tags at the same time. As such I assume when releasing we could
>>>> include two tags as part of a single release.
>>>>
>>>> Brock
>>>>
>>>> On Fri, Dec 21, 2012 at 3:02 PM, Dave Beech <da...@paraliatech.com> wrote:
>>>>> I've almost suggested the same thing while looking at a couple of the
>>>>> issues Patrick has raised. Too much has changed / is still changing between
>>>>> the hadoop 1 and 2 APIs. It's pretty much impossible already to cater to
>>>>> both and I don't see the situation improving. We already produce 2
>>>>> artifacts, so we might as well produce them from different branches. The
>>>>> end result for the user will be no different.
>>>>>
>>>>> Big +1 from me.
>>>>>
>>>>> Cheers
>>>>> Dave
>>>>>
>>>>>
>>>>> On 21 December 2012 19:40, Jarek Jarcec Cecho <ja...@apache.org> wrote:
>>>>>
>>>>>> We had recently similar incompatibility fight in Sqoop, so I can
>>>>>> understand your frustration.
>>>>>>
>>>>>> I'm +1 on the proposal.
>>>>>>
>>>>>> Jarcec
>>>>>>
>>>>>> On Fri, Dec 21, 2012 at 01:29:19PM -0600, Brock Noland wrote:
>>>>>> > Hi,
>>>>>> >
>>>>>> > In MRUNIT-31 we used mockito to allow a single branch of code work
>>>>>> > with hadoop 1 and hadoop 2. Patrick Hunt has filed a number of tickets
>>>>>> > for items which don't work with hadoop 2. I do not see an easy way to
>>>>>> > fix MRUNIT-167 and MRUNIT-161 in a single branch since hadoop 1 is
>>>>>> > lacking a large number of methods that hadoop 2 supports.
>>>>>> >
>>>>>> > As such, I think that we should think about the following:
>>>>>> >
>>>>>> > 1) Create hadoop-1 to support hadoop 1 with trunk supporting hadoop 2.
>>>>>> > 2) Resolve MRUNIT-167 and MRUNIT-161 in trunk.
>>>>>> > 3) Going forward we will have to backport from trunk to the hadoop-1
>>>>>> > branch. At first this will be simple since they are so similar. Over
>>>>>> > time this will become more difficult. Hopefully by the time it's too
>>>>>> > difficult to support hadoop-1 most people will have already moved to
>>>>>> > hadoop 2.
>>>>>> > 4) During releases we'll have to generate artifacts from both branches.
>>>>>> >
>>>>>> > Thoughts?
>>>>>> >
>>>>>> > --
>>>>>> > Apache MRUnit - Unit testing MapReduce -
>>>>>> http://incubator.apache.org/mrunit/
>>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
>>
>>
>>
>> --
>> Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
>
>
>
> --
> Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
--
Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/