You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/10 22:35:13 UTC
Re: Review Request 54407: Refactored Master::removeFramework to use
Master::deactivate.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54407/
-----------------------------------------------------------
(Updated Jan. 10, 2017, 10:35 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-6719
https://issues.apache.org/jira/browse/MESOS-6719
Repository: mesos
Description
-------
Refactored Master::removeFramework to use Master::deactivate.
Diffs (updated)
-----
src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
Diff: https://reviews.apache.org/r/54407/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 54407: Refactored Master::removeFramework to use
Master::deactivate.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54407/#review162737
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 13, 2017, 1:38 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54407/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 1:38 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6719
> https://issues.apache.org/jira/browse/MESOS-6719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored Master::removeFramework to use Master::deactivate.
>
>
> Diffs
> -----
>
> src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
> src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
>
> Diff: https://reviews.apache.org/r/54407/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 54407: Refactored Master::removeFramework to use
Master::deactivate.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54407/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 1:38 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Avoid rescinding offers when removing a framework.
Bugs: MESOS-6719
https://issues.apache.org/jira/browse/MESOS-6719
Repository: mesos
Description
-------
Refactored Master::removeFramework to use Master::deactivate.
Diffs (updated)
-----
src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
Diff: https://reviews.apache.org/r/54407/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 54407: Refactored Master::removeFramework to use
Master::deactivate.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54407/#review161159
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/54407/#comment232395>
I think we (I?) originially didn't call `deactivate` here because that causes rescind messages to be sent to the framework, which don't make sense here. Maybe `decativate` can take a `bool rescind`?
- Vinod Kone
On Jan. 10, 2017, 10:35 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54407/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 10:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6719
> https://issues.apache.org/jira/browse/MESOS-6719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored Master::removeFramework to use Master::deactivate.
>
>
> Diffs
> -----
>
> src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
>
> Diff: https://reviews.apache.org/r/54407/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>