You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2021/02/07 14:53:28 UTC

[isis] 04/12: ISIS-2444: reverses accidental edit of 'members' -> 'pathsToInclude'

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch ISIS-2444
in repository https://gitbox.apache.org/repos/asf/isis.git

commit 39c0cef949b673afbd967e92fc16a0bfe43eb033
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Sat Feb 6 14:29:18 2021 +0000

    ISIS-2444: reverses accidental edit of 'members' -> 'pathsToInclude'
    
    This must have happened a few weeks back when working on the XmlSnapshotService
---
 .../modules/runtime-services/pages/RepresentationService.adoc     | 2 +-
 security/bypass/src/main/adoc/modules/bypass/pages/about.adoc     | 2 +-
 .../adoc/modules/integtestsupport/pages/about.adoc                | 2 +-
 .../restfulobjects/adoc/modules/ROOT/pages/layout-resources.adoc  | 4 ++--
 viewers/restfulobjects/adoc/modules/ROOT/pages/ro-spec.adoc       | 8 ++++----
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/core/runtimeservices/src/main/adoc/modules/runtime-services/pages/RepresentationService.adoc b/core/runtimeservices/src/main/adoc/modules/runtime-services/pages/RepresentationService.adoc
index d801beb..301a643 100644
--- a/core/runtimeservices/src/main/adoc/modules/runtime-services/pages/RepresentationService.adoc
+++ b/core/runtimeservices/src/main/adoc/modules/runtime-services/pages/RepresentationService.adoc
@@ -65,7 +65,7 @@ These methods provide:
 +
 eg `ObjectAdapter`, `ObjectAndProperty`, `ObjectAndCollection` etc
 
-* for pathsToInclude, whether the representation is in read/write mode +
+* for members, whether the representation is in read/write mode +
 +
 ie `MemberReprMode`
 
diff --git a/security/bypass/src/main/adoc/modules/bypass/pages/about.adoc b/security/bypass/src/main/adoc/modules/bypass/pages/about.adoc
index 3556229..e0c5ac8 100644
--- a/security/bypass/src/main/adoc/modules/bypass/pages/about.adoc
+++ b/security/bypass/src/main/adoc/modules/bypass/pages/about.adoc
@@ -13,7 +13,7 @@ This is typically used for integration tests or for prototyping.
 
 The bypass security component consists of an implementation of both the `AuthenticationManager` and `AuthorizationManager` APIs, and are intended for prototyping use only.
 
-The authentication manager allows access with any credentials (in a sense, "bypassing" authentication), while the authorization manager provides access to all class pathsToInclude (in a sense, "bypassing" authorization).
+The authentication manager allows access with any credentials (in a sense, "bypassing" authentication), while the authorization manager provides access to all class members (in a sense, "bypassing" authorization).
 
 
 
diff --git a/testing/integtestsupport/adoc/modules/integtestsupport/pages/about.adoc b/testing/integtestsupport/adoc/modules/integtestsupport/pages/about.adoc
index 50b8a0a..123a595 100644
--- a/testing/integtestsupport/adoc/modules/integtestsupport/pages/about.adoc
+++ b/testing/integtestsupport/adoc/modules/integtestsupport/pages/about.adoc
@@ -451,7 +451,7 @@ We're not sure that's any easier (in fact we're certain it looks rather obscure)
 
 === Using the wrapper
 
-As the wrapper is intended to simulate the UI, only those methods that correspond to the "primary" methods of the domain object's pathsToInclude are allowed to be called.
+As the wrapper is intended to simulate the UI, only those methods that correspond to the "primary" methods of the domain object's members are allowed to be called.
 That means:
 
 * for *_object properties_* the test can call the getter or setter method
diff --git a/viewers/restfulobjects/adoc/modules/ROOT/pages/layout-resources.adoc b/viewers/restfulobjects/adoc/modules/ROOT/pages/layout-resources.adoc
index cb4c331..f1151f4 100644
--- a/viewers/restfulobjects/adoc/modules/ROOT/pages/layout-resources.adoc
+++ b/viewers/restfulobjects/adoc/modules/ROOT/pages/layout-resources.adoc
@@ -248,7 +248,7 @@ The representation returned by this resource is essentially exactly the same as
 
 The xref:vro:ROOT:layout-resources.adoc#menu-layout[menu layout] representation includes all possible domain services; it does not follow that the current user has access to all of these actions (some may be hidden or disabled).
 
-Similarly, the xref:vro:ROOT:layout-resources.adoc#domain-object-layout[domain object layout] representation include all _possible_ properties, collections and actions of the domain object; again, the current user may not have access to all of these pathsToInclude.
-It is also often the case that the domain object's internal state will determine which pathsToInclude to make available (eg, show only one of "lock" and "unlock" actions at any given time).
+Similarly, the xref:vro:ROOT:layout-resources.adoc#domain-object-layout[domain object layout] representation include all _possible_ properties, collections and actions of the domain object; again, the current user may not have access to all of these members.
+It is also often the case that the domain object's internal state will determine which members to make available (eg, show only one of "lock" and "unlock" actions at any given time).
 
 To determine what should actually be rendered, the REST client should follow the links to the standard Restful Objects resources.
diff --git a/viewers/restfulobjects/adoc/modules/ROOT/pages/ro-spec.adoc b/viewers/restfulobjects/adoc/modules/ROOT/pages/ro-spec.adoc
index d19747e..509c51e 100644
--- a/viewers/restfulobjects/adoc/modules/ROOT/pages/ro-spec.adoc
+++ b/viewers/restfulobjects/adoc/modules/ROOT/pages/ro-spec.adoc
@@ -134,19 +134,19 @@ The queries that are shown in the screencast include:
 
 * show parent and its children (titles) +
 +
-pass:[<pre>http://localhost:8080/restful/objects/PARENT/0?x-ro-follow-links=pathsToInclude[children\].value]
+pass:[<pre>http://localhost:8080/restful/objects/PARENT/0?x-ro-follow-links=members[children\].value]
 
 * show parent and its children (full details) +
 +
-pass:[<pre>http://localhost:8080/restful/objects/PARENT/0?x-ro-follow-links=pathsToInclude[children\].value.href]
+pass:[<pre>http://localhost:8080/restful/objects/PARENT/0?x-ro-follow-links=members[children\].value.href]
 
 * child's parent (title) +
 +
-pass:[<pre>http://localhost:8080/restful/objects/CHILD/0?x-ro-follow-links=pathsToInclude[parent\].value]
+pass:[<pre>http://localhost:8080/restful/objects/CHILD/0?x-ro-follow-links=members[parent\].value]
 
 * child's siblings (up to its parent, down to children) +
 +
-pass:[<pre>http://localhost:8080/restful/objects/CHILD/0?x-ro-follow-links=pathsToInclude[parent\].value.pathsToInclude[children\].value]
+pass:[<pre>http://localhost:8080/restful/objects/CHILD/0?x-ro-follow-links=members[parent\].value.members[children\].value]
 
 ==== Honor UI hints