You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@deltaspike.apache.org by st...@apache.org on 2012/10/10 20:15:56 UTC
[1/2] git commit: DELTASPIKE-277 create a proper unit test and remove
unused imports
Updated Branches:
refs/heads/master 53b3787e2 -> 649a65fae
DELTASPIKE-277 create a proper unit test and remove unused imports
Project: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/649a65fa
Tree: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/649a65fa
Diff: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/649a65fa
Branch: refs/heads/master
Commit: 649a65fae047377bf52978ef47f3d50020f1c048
Parents: 1bd79c9
Author: Mark Struberg <st...@apache.org>
Authored: Wed Oct 10 20:14:51 2012 +0200
Committer: Mark Struberg <st...@apache.org>
Committed: Wed Oct 10 20:14:51 2012 +0200
----------------------------------------------------------------------
.../jsf/impl/message/JsfMessageProducer.java | 1 -
.../test/jsf/impl/message/JsfMessageTest.java | 30 +++++++++++---
2 files changed, 23 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/649a65fa/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/message/JsfMessageProducer.java
----------------------------------------------------------------------
diff --git a/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/message/JsfMessageProducer.java b/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/message/JsfMessageProducer.java
index 2a26c82..ca5fca5 100644
--- a/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/message/JsfMessageProducer.java
+++ b/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/message/JsfMessageProducer.java
@@ -26,7 +26,6 @@ import javax.enterprise.inject.spi.InjectionPoint;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Type;
-import org.apache.deltaspike.core.util.ReflectionUtils;
import org.apache.deltaspike.jsf.message.JsfMessage;
/**
http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/649a65fa/deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/message/JsfMessageTest.java
----------------------------------------------------------------------
diff --git a/deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/message/JsfMessageTest.java b/deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/message/JsfMessageTest.java
index c01ff4d..2e1767a 100644
--- a/deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/message/JsfMessageTest.java
+++ b/deltaspike/modules/jsf/impl/src/test/java/org/apache/deltaspike/test/jsf/impl/message/JsfMessageTest.java
@@ -34,9 +34,13 @@ import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.jboss.shrinkwrap.api.asset.EmptyAsset;
import org.jboss.shrinkwrap.api.spec.WebArchive;
import org.junit.Test;
+import org.junit.Assert;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
+import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.WebElement;
+import org.openqa.selenium.support.ui.ExpectedConditions;
/**
@@ -76,15 +80,27 @@ public class JsfMessageTest
//X TODO remove, it's just for debugging the server side:
//X Thread.sleep(600000L);
-/*X
- WebElement inputField = driver.findElement(By.id("test:valueInput"));
- inputField.sendKeys("23");
- WebElement button = driver.findElement(By.id("test:saveButton"));
- button.click();
+ // check the JSF FacesMessages
+
+ Assert.assertNotNull(ExpectedConditions.presenceOfElementLocated(By.xpath("id('messages')")).apply(driver));
+
+ Assert.assertTrue(ExpectedConditions.textToBePresentInElement(
+ By.xpath("id('messages')/ul/li[1]"), "message with details warnInfo!").apply(driver));
+
+ Assert.assertTrue(ExpectedConditions.textToBePresentInElement(
+ By.xpath("id('messages')/ul/li[2]"), "message without detail but parameter errorInfo.").apply(driver));
+
+ Assert.assertTrue(ExpectedConditions.textToBePresentInElement(
+ By.xpath("id('messages')/ul/li[3]"), "a simple message without a param.").apply(driver));
+
+ Assert.assertTrue(ExpectedConditions.textToBePresentInElement(
+ By.xpath("id('messages')/ul/li[4]"), "simple message with a string param fatalInfo.").apply(driver));
+
+ // check the free message usage
+ Assert.assertTrue(ExpectedConditions.textToBePresentInElement(
+ By.id("test:valueOutput"), "a simple message without a param.").apply(driver));
- Assert.assertTrue(ExpectedConditions.textToBePresentInElement(By.id("test:valueOutput"), "23").apply(driver));
-*/
}
}