You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Kristian Marinkovic (JIRA)" <de...@tapestry.apache.org> on 2007/09/18 09:57:44 UTC

[jira] Created: (TAPESTRY-1754) Creating a service builder for ValidationDecorator for easier override

Creating a service builder for ValidationDecorator for easier override
----------------------------------------------------------------------

                 Key: TAPESTRY-1754
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1754
             Project: Tapestry
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.0, 5.0.6
            Reporter: Kristian Marinkovic
             Fix For: 5.0.6


A thread-scoped ValidationDecorator service could be easily overridden through an other decorator service. Tapestry's DefaultValidationDecorator does not necessarily meet the needs for field decoration. Exchanging the ValidationDecorator by replacing it in the Environment manually (as described http://www.nabble.com/How-to-create-my-ValidationDecorator-in-T5--tf4059742.html#a11533833) when it is globally needed seems cumbersome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-1754) Creating a service builder for ValidationDecorator for easier override

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-1754:
-------------------------------------------

    Fix Version/s:     (was: 5.0.6)
                   5.0.7

> Creating a service builder for ValidationDecorator for easier override
> ----------------------------------------------------------------------
>
>                 Key: TAPESTRY-1754
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1754
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0, 5.0.6
>            Reporter: Kristian Marinkovic
>             Fix For: 5.0.7
>
>
> A thread-scoped ValidationDecorator service could be easily overridden through an other decorator service. Tapestry's DefaultValidationDecorator does not necessarily meet the needs for field decoration. Exchanging the ValidationDecorator by replacing it in the Environment manually (as described http://www.nabble.com/How-to-create-my-ValidationDecorator-in-T5--tf4059742.html#a11533833) when it is globally needed seems cumbersome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-1754) Creating a service builder for ValidationDecorator for easier override

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-1754:
-------------------------------------------

    Fix Version/s:     (was: 5.0.7)
                   5.0.8

> Creating a service builder for ValidationDecorator for easier override
> ----------------------------------------------------------------------
>
>                 Key: TAPESTRY-1754
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1754
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0, 5.0.6
>            Reporter: Kristian Marinkovic
>             Fix For: 5.0.8
>
>         Attachments: TapestryModule.java
>
>
> A thread-scoped ValidationDecorator service could be easily overridden through an other decorator service. Tapestry's DefaultValidationDecorator does not necessarily meet the needs for field decoration. Exchanging the ValidationDecorator by replacing it in the Environment manually (as described http://www.nabble.com/How-to-create-my-ValidationDecorator-in-T5--tf4059742.html#a11533833) when it is globally needed seems cumbersome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Closed: (TAPESTRY-1754) Creating a service builder for ValidationDecorator for easier override

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAPESTRY-1754.
------------------------------------------

    Resolution: Won't Fix
      Assignee: Howard M. Lewis Ship

There were a bunch of changes in 5.0.7 related to this; it is now much easier to contribute an override of the default validation decorator:

 public void contributeMarkupRenderer(OrderedConfiguration<MarkupRendererFilter> configuration, final Environment environment)
{
  MarkupRendererFilter filter = new MarkupRendererFilter() {
    public void renderMarkup(MarkupWriter writer, MarkupRenderer renderer)
            {
               environment.push(ValidationDecorator.class, new MyValidationDecorator());

              renderer.renderMarkup(writer);

              environment.pop(ValidationDecorator.class);
         }
  };

  configuration.add("MyValidationDelegate", filter, "after:DefaultValidationDecorator");

}




   

> Creating a service builder for ValidationDecorator for easier override
> ----------------------------------------------------------------------
>
>                 Key: TAPESTRY-1754
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1754
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0, 5.0.6
>            Reporter: Kristian Marinkovic
>            Assignee: Howard M. Lewis Ship
>         Attachments: TapestryModule.java
>
>
> A thread-scoped ValidationDecorator service could be easily overridden through an other decorator service. Tapestry's DefaultValidationDecorator does not necessarily meet the needs for field decoration. Exchanging the ValidationDecorator by replacing it in the Environment manually (as described http://www.nabble.com/How-to-create-my-ValidationDecorator-in-T5--tf4059742.html#a11533833) when it is globally needed seems cumbersome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-1754) Creating a service builder for ValidationDecorator for easier override

Posted by "Kristian Marinkovic (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Marinkovic updated TAPESTRY-1754:
------------------------------------------

    Attachment: TapestryModule.java

DefaultValidationDecorator extracted as separate service of easier override

> Creating a service builder for ValidationDecorator for easier override
> ----------------------------------------------------------------------
>
>                 Key: TAPESTRY-1754
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1754
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.0, 5.0.6
>            Reporter: Kristian Marinkovic
>             Fix For: 5.0.7
>
>         Attachments: TapestryModule.java
>
>
> A thread-scoped ValidationDecorator service could be easily overridden through an other decorator service. Tapestry's DefaultValidationDecorator does not necessarily meet the needs for field decoration. Exchanging the ValidationDecorator by replacing it in the Environment manually (as described http://www.nabble.com/How-to-create-my-ValidationDecorator-in-T5--tf4059742.html#a11533833) when it is globally needed seems cumbersome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org