[GitHub] [spark] imback82 commented on a change in pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView

[GitBox <gi...@apache.org>]

imback82 commented on a change in pull request #30475:
URL: https://github.com/apache/spark/pull/30475#discussion_r529260212



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -729,7 +729,7 @@ class DataSourceV2SQLSuite
     val ex = intercept[AnalysisException] {
       sql("DROP TABLE testcat.db.notbl")
     }
-    assert(ex.getMessage.contains("Table or view not found: testcat.db.notbl"))
+    assert(ex.getMessage.contains("Table or view not found for 'DROP TABLE': testcat.db.notbl"))

Review comment:
       When I read `Table or view not found for 'DROP TABLE': t`, it sounded like `DROP TABLE` also supports permanent views.
   
   So, I was suggesting `Table or temporary view not found for 'DROP TABLE': t` since `DROP TABLE` requires either a table or temporary view. But, I guess `Table or view not found` sounds better if we want to point out the non-existing relation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org