You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by Joey Echeverria <jo...@gmail.com> on 2018/11/06 18:25:24 UTC

JIRA assignment

I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't assign
the issue to myself or update it's status in JIRA. Is there anything I
need to do to get JIRA updated?

Thanks!

-Joey

[1] https://github.com/apache/flink/pull/6862
[2] https://issues.apache.org/jira/browse/FLINK-10213

Re: JIRA assignment

Posted by Fabian Hueske <fh...@gmail.com>.

Hi Joey,

Thanks for your offer to help and contribute to Flink!

Testing a release candidate is always a much appreciated. A new RC for
Flink 1.7.0 should come out in the next days.
Regarding the backlog of PRs, everybody is welcome to help reviewing
contributions.  I would recommend to have a look at smaller PRs first.
Larger features sometimes need a discussion whether the feature should be
accepted or consensus on the overall design.

Best, Fabian

Am Fr., 16. Nov. 2018 um 21:09 Uhr schrieb Joey Echeverria <joey42@gmail.com
>:

> Thanks Fabian!
>
> Let me know if I can help with backlog of PRs or with the 1.7 release.
>
> -Joey
>
> On Fri, Nov 16, 2018 at 1:46 AM Fabian Hueske <fh...@gmail.com> wrote:
>
> > Hi Joey,
> >
> > First of all, sorry for the bad contribution experience so far.
> > I don't know the BlobManager well enough, otherwise I'd had a look at
> your
> > PR.
> >
> > The Flink community (and committers especially) are currently overwhelmed
> > with the number of PRs.
> > We receive all kinds of contributions from large features with 1000+ LOC
> > changes to bug fixes with very few changes (just like yours).
> > I think we need to improve how we handle smaller PRs that are (mostly)
> > relatively easy to review.
> > In general, I think it is fine to send out a reminder, especially for PRs
> > that fix a bug and should be easy to review.
> >
> > One thing that adds to the whole situation is that most of the committers
> > are currently working towards the 1.7.0 release and spent less time on PR
> > reviews.
> >
> > Best, Fabian
> >
> >
> > Am Do., 15. Nov. 2018 um 20:34 Uhr schrieb Joey Echeverria <
> > joey42@gmail.com>:
> >
> >> One quick follow up on this. The PR has been open for about a month. I
> >> don't want to bug the folks to review it, but I'm not sure what the
> >> etiquette is for getting PRs reviewed.
> >>
> >> Any help would be appreciated!
> >>
> >> Thanks!
> >>
> >> -Joey
> >>
> >> On Wed, Nov 7, 2018 at 6:44 AM Joey Echeverria <jo...@gmail.com>
> wrote:
> >>
> >> > Thanks Till!
> >> >
> >> > -Joey
> >> >
> >> > On Nov 7, 2018, at 02:32, Till Rohrmann <tr...@apache.org> wrote:
> >> >
> >> > I've given you permissions and assigned you to this ticket.
> >> >
> >> > Cheers,
> >> > Till
> >> >
> >> > On Tue, Nov 6, 2018 at 7:25 PM Joey Echeverria <jo...@gmail.com>
> >> wrote:
> >> >
> >> >> I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't
> >> assign
> >> >> the issue to myself or update it's status in JIRA. Is there anything
> I
> >> >> need to do to get JIRA updated?
> >> >>
> >> >> Thanks!
> >> >>
> >> >> -Joey
> >> >>
> >> >> [1] https://github.com/apache/flink/pull/6862
> >> >> [2] https://issues.apache.org/jira/browse/FLINK-10213
> >> >>
> >> >
> >>
> >
>

Re: JIRA assignment

Posted by Joey Echeverria <jo...@gmail.com>.

Thanks Fabian!

Let me know if I can help with backlog of PRs or with the 1.7 release.

-Joey

On Fri, Nov 16, 2018 at 1:46 AM Fabian Hueske <fh...@gmail.com> wrote:

> Hi Joey,
>
> First of all, sorry for the bad contribution experience so far.
> I don't know the BlobManager well enough, otherwise I'd had a look at your
> PR.
>
> The Flink community (and committers especially) are currently overwhelmed
> with the number of PRs.
> We receive all kinds of contributions from large features with 1000+ LOC
> changes to bug fixes with very few changes (just like yours).
> I think we need to improve how we handle smaller PRs that are (mostly)
> relatively easy to review.
> In general, I think it is fine to send out a reminder, especially for PRs
> that fix a bug and should be easy to review.
>
> One thing that adds to the whole situation is that most of the committers
> are currently working towards the 1.7.0 release and spent less time on PR
> reviews.
>
> Best, Fabian
>
>
> Am Do., 15. Nov. 2018 um 20:34 Uhr schrieb Joey Echeverria <
> joey42@gmail.com>:
>
>> One quick follow up on this. The PR has been open for about a month. I
>> don't want to bug the folks to review it, but I'm not sure what the
>> etiquette is for getting PRs reviewed.
>>
>> Any help would be appreciated!
>>
>> Thanks!
>>
>> -Joey
>>
>> On Wed, Nov 7, 2018 at 6:44 AM Joey Echeverria <jo...@gmail.com> wrote:
>>
>> > Thanks Till!
>> >
>> > -Joey
>> >
>> > On Nov 7, 2018, at 02:32, Till Rohrmann <tr...@apache.org> wrote:
>> >
>> > I've given you permissions and assigned you to this ticket.
>> >
>> > Cheers,
>> > Till
>> >
>> > On Tue, Nov 6, 2018 at 7:25 PM Joey Echeverria <jo...@gmail.com>
>> wrote:
>> >
>> >> I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't
>> assign
>> >> the issue to myself or update it's status in JIRA. Is there anything I
>> >> need to do to get JIRA updated?
>> >>
>> >> Thanks!
>> >>
>> >> -Joey
>> >>
>> >> [1] https://github.com/apache/flink/pull/6862
>> >> [2] https://issues.apache.org/jira/browse/FLINK-10213
>> >>
>> >
>>
>

Re: JIRA assignment

Posted by Fabian Hueske <fh...@gmail.com>.

Hi Joey,

First of all, sorry for the bad contribution experience so far.
I don't know the BlobManager well enough, otherwise I'd had a look at your
PR.

The Flink community (and committers especially) are currently overwhelmed
with the number of PRs.
We receive all kinds of contributions from large features with 1000+ LOC
changes to bug fixes with very few changes (just like yours).
I think we need to improve how we handle smaller PRs that are (mostly)
relatively easy to review.
In general, I think it is fine to send out a reminder, especially for PRs
that fix a bug and should be easy to review.

One thing that adds to the whole situation is that most of the committers
are currently working towards the 1.7.0 release and spent less time on PR
reviews.

Best, Fabian

Am Do., 15. Nov. 2018 um 20:34 Uhr schrieb Joey Echeverria <joey42@gmail.com
>:

> One quick follow up on this. The PR has been open for about a month. I
> don't want to bug the folks to review it, but I'm not sure what the
> etiquette is for getting PRs reviewed.
>
> Any help would be appreciated!
>
> Thanks!
>
> -Joey
>
> On Wed, Nov 7, 2018 at 6:44 AM Joey Echeverria <jo...@gmail.com> wrote:
>
> > Thanks Till!
> >
> > -Joey
> >
> > On Nov 7, 2018, at 02:32, Till Rohrmann <tr...@apache.org> wrote:
> >
> > I've given you permissions and assigned you to this ticket.
> >
> > Cheers,
> > Till
> >
> > On Tue, Nov 6, 2018 at 7:25 PM Joey Echeverria <jo...@gmail.com> wrote:
> >
> >> I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't assign
> >> the issue to myself or update it's status in JIRA. Is there anything I
> >> need to do to get JIRA updated?
> >>
> >> Thanks!
> >>
> >> -Joey
> >>
> >> [1] https://github.com/apache/flink/pull/6862
> >> [2] https://issues.apache.org/jira/browse/FLINK-10213
> >>
> >
>

Re: JIRA assignment

Posted by Joey Echeverria <jo...@gmail.com>.

One quick follow up on this. The PR has been open for about a month. I
don't want to bug the folks to review it, but I'm not sure what the
etiquette is for getting PRs reviewed.

Any help would be appreciated!

Thanks!

-Joey

On Wed, Nov 7, 2018 at 6:44 AM Joey Echeverria <jo...@gmail.com> wrote:

> Thanks Till!
>
> -Joey
>
> On Nov 7, 2018, at 02:32, Till Rohrmann <tr...@apache.org> wrote:
>
> I've given you permissions and assigned you to this ticket.
>
> Cheers,
> Till
>
> On Tue, Nov 6, 2018 at 7:25 PM Joey Echeverria <jo...@gmail.com> wrote:
>
>> I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't assign
>> the issue to myself or update it's status in JIRA. Is there anything I
>> need to do to get JIRA updated?
>>
>> Thanks!
>>
>> -Joey
>>
>> [1] https://github.com/apache/flink/pull/6862
>> [2] https://issues.apache.org/jira/browse/FLINK-10213
>>
>

Re: JIRA assignment

Posted by Joey Echeverria <jo...@gmail.com>.

Thanks Till!

-Joey

> On Nov 7, 2018, at 02:32, Till Rohrmann <tr...@apache.org> wrote:
> 
> I've given you permissions and assigned you to this ticket.
> 
> Cheers,
> Till
> 
>> On Tue, Nov 6, 2018 at 7:25 PM Joey Echeverria <jo...@gmail.com> wrote:
>> I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't assign
>> the issue to myself or update it's status in JIRA. Is there anything I
>> need to do to get JIRA updated?
>> 
>> Thanks!
>> 
>> -Joey
>> 
>> [1] https://github.com/apache/flink/pull/6862
>> [2] https://issues.apache.org/jira/browse/FLINK-10213

Re: JIRA assignment

Posted by Till Rohrmann <tr...@apache.org>.

I've given you permissions and assigned you to this ticket.

Cheers,
Till

On Tue, Nov 6, 2018 at 7:25 PM Joey Echeverria <jo...@gmail.com> wrote:

> I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't assign
> the issue to myself or update it's status in JIRA. Is there anything I
> need to do to get JIRA updated?
>
> Thanks!
>
> -Joey
>
> [1] https://github.com/apache/flink/pull/6862
> [2] https://issues.apache.org/jira/browse/FLINK-10213
>