You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/06/28 18:11:07 UTC

Review Request 49331: GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49331/
-----------------------------------------------------------

Review request for geode, Kirk Lund and Dan Smith.


Repository: geode


Description
-------

GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java ab2ce627524dc1a3c99b4a3b2f5f1312a9f990bf 

Diff: https://reviews.apache.org/r/49331/diff/


Testing
-------


Thanks,

Jinmei Liao

Re: Review Request 49331: GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest

Posted by Kevin Duling <kd...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49331/#review139844
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Duling


On June 28, 2016, 11:11 a.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49331/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 11:11 a.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java ab2ce627524dc1a3c99b4a3b2f5f1312a9f990bf 
> 
> Diff: https://reviews.apache.org/r/49331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 49331: GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest

Posted by Jinmei Liao <ji...@pivotal.io>.


> On June 28, 2016, 6:20 p.m., Kirk Lund wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java, line 175
> > <https://reviews.apache.org/r/49331/diff/1/?file=1432016#file1432016line175>
> >
> >     Another alternative is to add an @Before method to CommandOverHttpDUnitTest and move these addIgnoredException stmts there. Either way, ship it!

I tried that. The @Before function was not get called ever. I think it's because CommandOverHttpDUnitTest is a testSuite, not a test class.


- Jinmei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49331/#review139832
-----------------------------------------------------------


On June 28, 2016, 6:11 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49331/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 6:11 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java ab2ce627524dc1a3c99b4a3b2f5f1312a9f990bf 
> 
> Diff: https://reviews.apache.org/r/49331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 49331: GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest

Posted by Kirk Lund <ki...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49331/#review139832
-----------------------------------------------------------


Ship it!





geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java (line 160)
<https://reviews.apache.org/r/49331/#comment205188>

    Another alternative is to add an @Before method to CommandOverHttpDUnitTest and move these addIgnoredException stmts there. Either way, ship it!


- Kirk Lund


On June 28, 2016, 6:11 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49331/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 6:11 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java ab2ce627524dc1a3c99b4a3b2f5f1312a9f990bf 
> 
> Diff: https://reviews.apache.org/r/49331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 49331: GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest

Posted by Dan Smith <ds...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49331/#review139845
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On June 28, 2016, 6:11 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49331/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 6:11 p.m.)
> 
> 
> Review request for geode, Kirk Lund and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1551: add ignoredExcpetions for CommandOverHttpDUnitTest
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CliCommandTestBase.java ab2ce627524dc1a3c99b4a3b2f5f1312a9f990bf 
> 
> Diff: https://reviews.apache.org/r/49331/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>