[GitHub] [spark] williamhyun commented on a change in pull request #35015: [SPARK-37735][K8S] Add appId interface to KubernetesConf

[GitBox <gi...@apache.org>]

williamhyun commented on a change in pull request #35015:
URL: https://github.com/apache/spark/pull/35015#discussion_r776562906



##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
##########
@@ -218,6 +218,14 @@ class KubernetesConfSuite extends SparkFunSuite {
     assert(driverConf.schedulerName === "driverScheduler")
   }
 
+  test("SPARK-37735: access appId in KubernetesConf") {
+    val sparkConf = new SparkConf(false)
+    val execConf = KubernetesTestConf.createExecutorConf(sparkConf)
+    val driverConf = KubernetesTestConf.createExecutorConf(sparkConf)

Review comment:
       Is `createExecutorConf` a typo? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org