You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/04 16:38:46 UTC

[GitHub] [flink] fpompermaier opened a new pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

fpompermaier opened a new pull request #11986:
URL: https://github.com/apache/flink/pull/11986


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Enable users to create a JDBC source table using a custom query / prepared statement.
   
   
   ## Brief change log
   
   - Managed 'connector.read.query' to create a (read-only) source table using a custom query.
   - Currently a read-only Table cannot be created. When a final decision will be taken on that we should set such a flag for tables having such a property
   - When a final decision will be made for renaming of connector properties this property could probably become simply 'scan.query', but I decided to left the renaming of those properties to another specific PR
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *JDBCTableSourceSinkFactoryTest* and *JDBCTableSourceITCase*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): *no*
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: *no*
     - The serializers: *no*
     - The runtime per-record code paths (performance sensitive): *no*
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper:*no*
     - The S3 file system connector: *no*
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-630907267


   @fpompermaier I rebased this on `master` and modified the `ITCase` to use the new `TableResult`. If you're ok with the changes I'll wait for azure and then merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ef38bb803e299713253d441f42379776d21c3f87",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ef38bb803e299713253d441f42379776d21c3f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1597769183be673722456fb55e296d38d0fad837 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584) 
   * ef38bb803e299713253d441f42379776d21c3f87 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cc9434270958dcbdf322483531c97c108c4a2e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1597769183be673722456fb55e296d38d0fad837 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ef38bb803e299713253d441f42379776d21c3f87",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749",
       "triggerID" : "ef38bb803e299713253d441f42379776d21c3f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ef38bb803e299713253d441f42379776d21c3f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ef38bb803e299713253d441f42379776d21c3f87",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749",
       "triggerID" : "ef38bb803e299713253d441f42379776d21c3f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c15ff1d0641386ad0151880c9e84a8853ba5cd9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1878",
       "triggerID" : "8c15ff1d0641386ad0151880c9e84a8853ba5cd9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ef38bb803e299713253d441f42379776d21c3f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749) 
   * 8c15ff1d0641386ad0151880c9e84a8853ba5cd9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1878) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623574742


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8c15ff1d0641386ad0151880c9e84a8853ba5cd9 (Fri Oct 16 10:53:51 UTC 2020)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] fpompermaier commented on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
fpompermaier commented on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-631035275


   Thanks a lot @aljoscha 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cc9434270958dcbdf322483531c97c108c4a2e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571) 
   * 1597769183be673722456fb55e296d38d0fad837 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #11986:
URL: https://github.com/apache/flink/pull/11986#discussion_r429174832



##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceITCase.java
##########
@@ -143,20 +149,19 @@ public void testProjectableJdbcSource() throws Exception {
 				")"
 		);
 
-		StreamITCase.clear();
-		tEnv.toAppendStream(tEnv.sqlQuery("SELECT timestamp6_col, decimal_col FROM " + INPUT_TABLE), Row.class)
-				.addSink(new StreamITCase.StringSink<>());
-		env.execute();
+		TableResult tableResult = tEnv.executeSql("SELECT timestamp6_col, decimal_col FROM " + INPUT_TABLE);
+
+		List<String> results = manifestResults(tableResult);
 
-		List<String> expected =
-			Arrays.asList(
-				"2020-01-01T15:35:00.123456,100.1234",
-				"2020-01-01T15:36:01.123456,101.1234");
-		StreamITCase.compareWithList(expected);
+		assertThat(
+				results,
+				containsInAnyOrder(
+						"2020-01-01T15:35:00.123456,100.1234",

Review comment:
       Noted, that's a very good point.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cc9434270958dcbdf322483531c97c108c4a2e8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #11986:
URL: https://github.com/apache/flink/pull/11986#discussion_r421464138



##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java
##########
@@ -153,4 +153,34 @@ public void testProjectableJDBCSource() throws Exception {
 				"2020-01-01T15:36:01.123456,101.1234");
 		StreamITCase.compareWithList(expected);
 	}
+
+	@Test
+	public void testScanQueryJDBCSource() throws Exception {
+		StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+		EnvironmentSettings envSettings = EnvironmentSettings.newInstance()
+			.useBlinkPlanner()
+			.inStreamingMode()
+			.build();
+		StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, envSettings);
+
+		final String testQuery = "SELECT id FROM " + INPUT_TABLE;
+		tEnv.sqlUpdate(
+			"CREATE TABLE test(" +
+				"id BIGINT" +
+				") WITH (" +
+				"  'connector.type'='jdbc'," +
+				"  'connector.url'='" + DB_URL + "'," +
+				"  'connector.table'='whatever'," +
+				"  'connector.read.query'='" + testQuery + "'" +
+				")"
+		);
+
+		StreamITCase.clear();

Review comment:
       I understand, the code code that is there is already not good. 😞




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11986:
URL: https://github.com/apache/flink/pull/11986#discussion_r427773573



##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceITCase.java
##########
@@ -143,20 +149,19 @@ public void testProjectableJdbcSource() throws Exception {
 				")"
 		);
 
-		StreamITCase.clear();
-		tEnv.toAppendStream(tEnv.sqlQuery("SELECT timestamp6_col, decimal_col FROM " + INPUT_TABLE), Row.class)
-				.addSink(new StreamITCase.StringSink<>());
-		env.execute();
+		TableResult tableResult = tEnv.executeSql("SELECT timestamp6_col, decimal_col FROM " + INPUT_TABLE);
+
+		List<String> results = manifestResults(tableResult);
 
-		List<String> expected =
-			Arrays.asList(
-				"2020-01-01T15:35:00.123456,100.1234",
-				"2020-01-01T15:36:01.123456,101.1234");
-		StreamITCase.compareWithList(expected);
+		assertThat(
+				results,
+				containsInAnyOrder(
+						"2020-01-01T15:35:00.123456,100.1234",

Review comment:
       @aljoscha for the future: please use instances instead of strings




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-630980440


   Thanks a lot! I merged it before you answered, I hope that's ok. (I wanted to get it in in time for Flink 1.11)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ef38bb803e299713253d441f42379776d21c3f87",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749",
       "triggerID" : "ef38bb803e299713253d441f42379776d21c3f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8c15ff1d0641386ad0151880c9e84a8853ba5cd9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8c15ff1d0641386ad0151880c9e84a8853ba5cd9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ef38bb803e299713253d441f42379776d21c3f87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749) 
   * 8c15ff1d0641386ad0151880c9e84a8853ba5cd9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #11986:
URL: https://github.com/apache/flink/pull/11986#discussion_r421365481



##########
File path: docs/dev/table/connect.md
##########
@@ -1284,7 +1284,11 @@ CREATE TABLE MyUserTable (
   'connector.username' = 'name',
   'connector.password' = 'password',
   
-  -- **followings are scan options, optional, used when reading from table**
+  -- **followings are scan options, optional, used when reading from a table**
+
+  -- optional: SQL query / prepared statement.
+  -- If set, it will takes over the 'connector.table' setting
+  'connector.read.query' = 'SELECT * FROM sometable',

Review comment:
       ```suggestion
     -- optional: SQL query / prepared statement.
     -- If set, this will take precedence over the 'connector.table' setting
     'connector.read.query' = 'SELECT * FROM sometable',
   ```

##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java
##########
@@ -153,4 +153,34 @@ public void testProjectableJDBCSource() throws Exception {
 				"2020-01-01T15:36:01.123456,101.1234");
 		StreamITCase.compareWithList(expected);
 	}
+
+	@Test
+	public void testScanQueryJDBCSource() throws Exception {
+		StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+		EnvironmentSettings envSettings = EnvironmentSettings.newInstance()
+			.useBlinkPlanner()
+			.inStreamingMode()
+			.build();
+		StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, envSettings);
+
+		final String testQuery = "SELECT id FROM " + INPUT_TABLE;
+		tEnv.sqlUpdate(
+			"CREATE TABLE test(" +
+				"id BIGINT" +
+				") WITH (" +
+				"  'connector.type'='jdbc'," +
+				"  'connector.url'='" + DB_URL + "'," +
+				"  'connector.table'='whatever'," +
+				"  'connector.read.query'='" + testQuery + "'" +
+				")"
+		);
+
+		StreamITCase.clear();

Review comment:
       I think using the static `StreamITCase` functionality here is an anti-pattern that we should avoid. (I know that it's widely used in the code base, but we should rid of it at some point.)
   
   Ideally, with the FLIP-84 work it should be as easy as
   ```
   TableResult tableResult = tEnv.executeSql("SELECT timestamp6_col, decimal_col FROM " + INPUT_TABLE);
   tableResult.collect();
   ```
   
   but that is not yet in master. I'm inclined to wait for a but but basically have this PR ready in a mergable state.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623574742


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4cc9434270958dcbdf322483531c97c108c4a2e8 (Mon May 04 16:41:58 UTC 2020)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17361).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cc9434270958dcbdf322483531c97c108c4a2e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571) 
   * 1597769183be673722456fb55e296d38d0fad837 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cc9434270958dcbdf322483531c97c108c4a2e8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha merged pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #11986:
URL: https://github.com/apache/flink/pull/11986


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] fpompermaier commented on a change in pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
fpompermaier commented on a change in pull request #11986:
URL: https://github.com/apache/flink/pull/11986#discussion_r421450567



##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java
##########
@@ -153,4 +153,34 @@ public void testProjectableJDBCSource() throws Exception {
 				"2020-01-01T15:36:01.123456,101.1234");
 		StreamITCase.compareWithList(expected);
 	}
+
+	@Test
+	public void testScanQueryJDBCSource() throws Exception {
+		StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+		EnvironmentSettings envSettings = EnvironmentSettings.newInstance()
+			.useBlinkPlanner()
+			.inStreamingMode()
+			.build();
+		StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, envSettings);
+
+		final String testQuery = "SELECT id FROM " + INPUT_TABLE;
+		tEnv.sqlUpdate(
+			"CREATE TABLE test(" +
+				"id BIGINT" +
+				") WITH (" +
+				"  'connector.type'='jdbc'," +
+				"  'connector.url'='" + DB_URL + "'," +
+				"  'connector.table'='whatever'," +
+				"  'connector.read.query'='" + testQuery + "'" +
+				")"
+		);
+
+		StreamITCase.clear();

Review comment:
       I just copied the code from another test and I modifier it. I didn't ask myself too much why there's the need to call StreamITCase.clear()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11986:
URL: https://github.com/apache/flink/pull/11986#issuecomment-623579672


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=571",
       "triggerID" : "4cc9434270958dcbdf322483531c97c108c4a2e8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1597769183be673722456fb55e296d38d0fad837",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584",
       "triggerID" : "1597769183be673722456fb55e296d38d0fad837",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ef38bb803e299713253d441f42379776d21c3f87",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749",
       "triggerID" : "ef38bb803e299713253d441f42379776d21c3f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1597769183be673722456fb55e296d38d0fad837 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=584) 
   * ef38bb803e299713253d441f42379776d21c3f87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=749) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] fpompermaier commented on a change in pull request #11986: [FLINK-17361] [jdbc] Added custom query on JDBC tables

Posted by GitBox <gi...@apache.org>.
fpompermaier commented on a change in pull request #11986:
URL: https://github.com/apache/flink/pull/11986#discussion_r421488963



##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTableSourceITCase.java
##########
@@ -153,4 +153,34 @@ public void testProjectableJDBCSource() throws Exception {
 				"2020-01-01T15:36:01.123456,101.1234");
 		StreamITCase.compareWithList(expected);
 	}
+
+	@Test
+	public void testScanQueryJDBCSource() throws Exception {
+		StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+		EnvironmentSettings envSettings = EnvironmentSettings.newInstance()
+			.useBlinkPlanner()
+			.inStreamingMode()
+			.build();
+		StreamTableEnvironment tEnv = StreamTableEnvironment.create(env, envSettings);
+
+		final String testQuery = "SELECT id FROM " + INPUT_TABLE;
+		tEnv.sqlUpdate(
+			"CREATE TABLE test(" +
+				"id BIGINT" +
+				") WITH (" +
+				"  'connector.type'='jdbc'," +
+				"  'connector.url'='" + DB_URL + "'," +
+				"  'connector.table'='whatever'," +
+				"  'connector.read.query'='" + testQuery + "'" +
+				")"
+		);
+
+		StreamITCase.clear();

Review comment:
       Maybe we can merge this and open an issue to fix the tests in this class to the right way when FLIP-84 will be ready




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org