You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/08/03 04:59:12 UTC

[GitHub] jiazhai opened a new pull request #2301: Issue #1452: remove reachedEndOfTopic in addConsumer

jiazhai opened a new pull request #2301: Issue #1452: remove reachedEndOfTopic in addConsumer
URL: https://github.com/apache/incubator-pulsar/pull/2301
 
 
   ### Motivation
   
   reachedEndOfTopic was called twice if a topic has been terminated before subscription.
   It may be better to call `reachedEndOfTopic`, when real/ack happened to the subscription, so delete the calling in `addConsumer` to avoid dup calling.
   
   ### Modifications
   
   remove dup calling in `addConsumer` .
   add related ut.
   
   ### Result
   
   Expected all ut passed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services