You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Anthony Giardullo (JIRA)" <ji...@apache.org> on 2009/03/04 06:33:56 UTC

[jira] Issue Comment Edited: (THRIFT-265) Buffer bloat in TNonblockingServer

    [ https://issues.apache.org/jira/browse/THRIFT-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678566#action_12678566 ] 

agiardullo edited comment on THRIFT-265 at 3/3/09 9:33 PM:
------------------------------------------------------------------

I believe the realloc call in TNonBlockingServer should be using 1024 instead of readBufferSize_.

Also, how about instead of hard coding the limit to 512, we make this value configurable? (This feature can then be disabled by setting this value to MAX_INT).

      was (Author: agiardullo):
    I believe the realloc call in TNonBlockingServer should be using 1024 instead of readBufferSize_.

Also, how about instead of hard coding the limit to 512, we make this value configurable? (And disabling this feature if the value is set to 0).
  
> Buffer bloat in TNonblockingServer
> ----------------------------------
>
>                 Key: THRIFT-265
>                 URL: https://issues.apache.org/jira/browse/THRIFT-265
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (C++)
>            Reporter: Erik Frey
>            Assignee: Erik Frey
>            Priority: Minor
>         Attachments: buffer_reset.patch, graph.png
>
>
> TNonBlockingServer never resets the lengths of the buffers it maintains for reading and writing.  Servers with a long life and many concurrent connections eventually generate an overhead that can reach into the gigabytes, particularly in services that have varied message sizes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.