[GitHub] [airflow] ianbuss commented on pull request #24658: Add `airflow_kpo_in_cluster` label to KPO pods

[GitBox <gi...@apache.org>]

ianbuss commented on PR #24658:
URL: https://github.com/apache/airflow/pull/24658#issuecomment-1167092658

   Just thinking out loud, would it make sense to (also?) add the full task spec as json to a KPO label to allow maximum future flexibility in the pod mutation hook to make mutation decisions. I realise the `in_cluster` here is more complicated than if the user specifies `in_cluster=True|False` on the task as it looks for global Airflow configs and also connection config but there may be things in the future that we haven't considered that users might want to use in their mutation logic.
   
   The alternative would be to extend the `pod_mutation_hook` function signature to accept a `KubernetesPodOperator` argument but not sure how/if this could be done in a backwards-compatible way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org