You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/09/07 12:25:03 UTC

[GitHub] [echarts] 100pah opened a new pull request #15686: fix: Fix MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format

100pah opened a new pull request #15686:
URL: https://github.com/apache/echarts/pull/15686


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   Fix MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format. 
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   Fix #15675 .
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format. 
   
   It brought by https://github.com/apache/echarts/pull/15355, 
   where 
   ```ts
   const dataCtors = {
       'float': CtorFloat64Array,
       'int': CtorInt32Array,
       'ordinal': Array,
       'number': Array,
       // original time is Array, not changed to TypedArray.
       'time': CtorFloat64Array
   } as const;
   ```
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   Displayed as before.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] 100pah merged pull request #15686: fix: Fix MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format

Posted by GitBox <gi...@apache.org>.
100pah merged pull request #15686:
URL: https://github.com/apache/echarts/pull/15686


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15686: fix: Fix MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15686:
URL: https://github.com/apache/echarts/pull/15686#issuecomment-914263000


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15686: fix: Fix MarkLine/MarkPoint/MarkArea do not work on time axis if input string time format

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15686:
URL: https://github.com/apache/echarts/pull/15686#issuecomment-914259503


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org