You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Raul Castro Fernandez (JIRA)" <ji...@apache.org> on 2014/06/11 20:54:04 UTC
[jira] [Commented] (KAFKA-179) Log files always touched when broker
is bounced
[ https://issues.apache.org/jira/browse/KAFKA-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028219#comment-14028219 ]
Raul Castro Fernandez commented on KAFKA-179:
---------------------------------------------
The function recoverLog() in Log.scala checks whether the log has the CleanShutdownMarker. If it exists, then it returns without touching any MessageSet (lines 173-176). Does the description of the JIRA refers to this function?
> Log files always touched when broker is bounced
> -----------------------------------------------
>
> Key: KAFKA-179
> URL: https://issues.apache.org/jira/browse/KAFKA-179
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Joel Koshy
> Priority: Minor
> Labels: newbie
> Fix For: 0.8.2
>
>
> It looks like the latest log segment is always touched when the broker upon start-up regardless of whether it has corrupt data or not, which fudges the segment's mtime. Minor issue, but I found it a bit misleading when trying to verify a log cleanup setting in production. I think it should be as simple as adding a guard in FileMessageSet's recover method to skip truncate if validUpTo == the length of the segment. Will test this later.
--
This message was sent by Atlassian JIRA
(v6.2#6252)