You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 20:54:50 UTC
[GitHub] [airflow] kaxil opened a new pull request #16514: Fix package version in ``LICENSE`` file
kaxil opened a new pull request #16514:
URL: https://github.com/apache/airflow/pull/16514
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in https://github.com/apache/airflow/pull/11035
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #16514: Fix package version in ``LICENSE`` file
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #16514:
URL: https://github.com/apache/airflow/pull/16514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #16514: Fix package version in ``LICENSE`` file
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #16514:
URL: https://github.com/apache/airflow/pull/16514#discussion_r654027316
##########
File path: LICENSE
##########
@@ -229,23 +229,22 @@ MIT licenses
The following components are provided under the MIT License. See project link for details.
The text of each license is also included at licenses/LICENSE-[project].txt.
- (MIT License) jquery v3.4.1 (https://jquery.org/license/)
+ (MIT License) jquery v3.5.1 (https://jquery.org/license/)
(MIT License) dagre-d3 v0.6.4 (https://github.com/cpettitt/dagre-d3)
- (MIT License) bootstrap v3.2 (https://github.com/twbs/bootstrap/)
+ (MIT License) bootstrap v3.4.1 (https://github.com/twbs/bootstrap/)
(MIT License) d3-tip v0.9.1 (https://github.com/Caged/d3-tip)
- (MIT License) dataTables v1.10.20 (https://datatables.net)
- (MIT License) Bootstrap Toggle v2.2.2 (http://www.bootstraptoggle.com)
Review comment:
We removed it in #11035
##########
File path: LICENSE
##########
@@ -229,23 +229,22 @@ MIT licenses
The following components are provided under the MIT License. See project link for details.
The text of each license is also included at licenses/LICENSE-[project].txt.
- (MIT License) jquery v3.4.1 (https://jquery.org/license/)
+ (MIT License) jquery v3.5.1 (https://jquery.org/license/)
(MIT License) dagre-d3 v0.6.4 (https://github.com/cpettitt/dagre-d3)
- (MIT License) bootstrap v3.2 (https://github.com/twbs/bootstrap/)
+ (MIT License) bootstrap v3.4.1 (https://github.com/twbs/bootstrap/)
(MIT License) d3-tip v0.9.1 (https://github.com/Caged/d3-tip)
- (MIT License) dataTables v1.10.20 (https://datatables.net)
- (MIT License) Bootstrap Toggle v2.2.2 (http://www.bootstraptoggle.com)
Review comment:
We removed it in https://github.com/apache/airflow/pull/11035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16514: Fix package version in ``LICENSE`` file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16514:
URL: https://github.com/apache/airflow/pull/16514#issuecomment-863761037
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org