You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "junheleo (Jira)" <ji...@apache.org> on 2023/05/05 09:59:00 UTC
[jira] [Updated] (CALCITE-5689) MV Rewrite failed when the project field is on the nullable side of the join using JoinOnCalcsToJoinUnifyRule
[ https://issues.apache.org/jira/browse/CALCITE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
junheleo updated CALCITE-5689:
------------------------------
Description:
As shown in the following example:
{code:java}
String mv = ""
+ "select * from\n"
+ " (select * from \"emps\") \"A\"\n"
+ " left join\n"
+ " (select \"deptno\",\"name\" from \"depts\") \"B\"\n"
+ " on \"A\".\"deptno\" = \"B\".\"deptno\"";
String query = ""
+ "select \"A\".\"deptno\",\"B\".\"deptno\" from\n"
+ " (select \"deptno\" from \"emps\") \"A\"\n"
+ " left join\n"
+ " (select \"deptno\" from \"depts\" ) \"B\"\n"
+ " on \"A\".\"deptno\" = \"B\".\"deptno\"";
sql(mv, query).ok(); {code}
It failed with the following messages：
{code:java}
java.lang.AssertionError: type mismatch:
type1:
JavaType(int) NOT NULL
type2:
JavaType(class java.lang.Integer) at org.apache.calcite.util.Litmus$1.fail(Litmus.java:32)
at org.apache.calcite.plan.RelOptUtil.eq(RelOptUtil.java:2211)
at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:953)
at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:931)
at org.apache.calcite.rex.RexInputRef.accept(RexInputRef.java:114)
at org.apache.calcite.rex.RexProgramBuilder.registerInput(RexProgramBuilder.java:302)
at org.apache.calcite.rex.RexProgramBuilder.addProject(RexProgramBuilder.java:212)
at org.apache.calcite.rex.RexProgram.create(RexProgram.java:235)
at org.apache.calcite.rex.RexProgram.create(RexProgram.java:204)
at org.apache.calcite.plan.SubstitutionVisitor$JoinOnCalcsToJoinUnifyRule.apply(SubstitutionVisitor.java:1446)
at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:585)
at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:519)
at org.apache.calcite.test.MaterializedViewSubstitutionVisitorTest$1.optimize(MaterializedViewSubstitutionVisitorTest.java:94)
at org.apache.calcite.test.MaterializedViewTester.checkMaterialize(MaterializedViewTester.java:78)
at org.apache.calcite.test.MaterializedViewFixture.ok(MaterializedViewFixture.java:56)
at org.apache.calcite.test.MaterializedViewSubstitutionVisitorTest.testJoinOnRightProjectToJoin(MaterializedViewSubstitutionVisitorTest.java:775){code}
Field B.deptno is considered non-null in the join input but becomes nullable after the join, resulting in a type mismatch.
Similar cases also occur in JoinOnRightCalcToJoinUnifyRule and JoinOnLeftCalcToJoinUnifyRule
was:
As shown in the following example:
{code:java}
String mv = ""
+ "select * from\n"
+ " (select * from \"emps\") \"A\"\n"
+ " left join\n"
+ " (select \"deptno\",\"name\" from \"depts\") \"B\"\n"
+ " on \"A\".\"deptno\" = \"B\".\"deptno\"";
String query = ""
+ "select \"A\".\"deptno\",\"B\".\"deptno\" from\n"
+ " (select \"deptno\" from \"emps\") \"A\"\n"
+ " left join\n"
+ " (select \"deptno\" from \"depts\" ) \"B\"\n"
+ " on \"A\".\"deptno\" = \"B\".\"deptno\"";
sql(mv, query).ok(); {code}
It failed with the following messages
{code:java}
java.lang.AssertionError: type mismatch:
type1:
JavaType(int) NOT NULL
type2:
JavaType(class java.lang.Integer) at org.apache.calcite.util.Litmus$1.fail(Litmus.java:32)
at org.apache.calcite.plan.RelOptUtil.eq(RelOptUtil.java:2211)
at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:953)
at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:931)
at org.apache.calcite.rex.RexInputRef.accept(RexInputRef.java:114)
at org.apache.calcite.rex.RexProgramBuilder.registerInput(RexProgramBuilder.java:302)
at org.apache.calcite.rex.RexProgramBuilder.addProject(RexProgramBuilder.java:212)
at org.apache.calcite.rex.RexProgram.create(RexProgram.java:235)
at org.apache.calcite.rex.RexProgram.create(RexProgram.java:204)
at org.apache.calcite.plan.SubstitutionVisitor$JoinOnCalcsToJoinUnifyRule.apply(SubstitutionVisitor.java:1446)
at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:585)
at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:519)
at org.apache.calcite.test.MaterializedViewSubstitutionVisitorTest$1.optimize(MaterializedViewSubstitutionVisitorTest.java:94)
at org.apache.calcite.test.MaterializedViewTester.checkMaterialize(MaterializedViewTester.java:78)
at org.apache.calcite.test.MaterializedViewFixture.ok(MaterializedViewFixture.java:56)
at org.apache.calcite.test.MaterializedViewSubstitutionVisitorTest.testJoinOnRightProjectToJoin(MaterializedViewSubstitutionVisitorTest.java:775)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.util.ArrayList.forEach(ArrayList.java:1257)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.util.ArrayList.forEach(ArrayList.java:1257)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:53)
at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54) {code}
Field B.deptno is considered non-null in the join input but becomes nullable after the join, resulting in a type mismatch.
Similar cases also occur in JoinOnRightCalcToJoinUnifyRule and JoinOnLeftCalcToJoinUnifyRule
> MV Rewrite failed when the project field is on the nullable side of the join using JoinOnCalcsToJoinUnifyRule
> -------------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5689
> URL: https://issues.apache.org/jira/browse/CALCITE-5689
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: junheleo
> Assignee: junheleo
> Priority: Minor
>
> As shown in the following example:
> {code:java}
> String mv = ""
> + "select * from\n"
> + " (select * from \"emps\") \"A\"\n"
> + " left join\n"
> + " (select \"deptno\",\"name\" from \"depts\") \"B\"\n"
> + " on \"A\".\"deptno\" = \"B\".\"deptno\"";
> String query = ""
> + "select \"A\".\"deptno\",\"B\".\"deptno\" from\n"
> + " (select \"deptno\" from \"emps\") \"A\"\n"
> + " left join\n"
> + " (select \"deptno\" from \"depts\" ) \"B\"\n"
> + " on \"A\".\"deptno\" = \"B\".\"deptno\"";
> sql(mv, query).ok(); {code}
> It failed with the following messages：
> {code:java}
> java.lang.AssertionError: type mismatch:
> type1:
> JavaType(int) NOT NULL
> type2:
> JavaType(class java.lang.Integer) at org.apache.calcite.util.Litmus$1.fail(Litmus.java:32)
> at org.apache.calcite.plan.RelOptUtil.eq(RelOptUtil.java:2211)
> at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:953)
> at org.apache.calcite.rex.RexProgramBuilder$RegisterInputShuttle.visitInputRef(RexProgramBuilder.java:931)
> at org.apache.calcite.rex.RexInputRef.accept(RexInputRef.java:114)
> at org.apache.calcite.rex.RexProgramBuilder.registerInput(RexProgramBuilder.java:302)
> at org.apache.calcite.rex.RexProgramBuilder.addProject(RexProgramBuilder.java:212)
> at org.apache.calcite.rex.RexProgram.create(RexProgram.java:235)
> at org.apache.calcite.rex.RexProgram.create(RexProgram.java:204)
> at org.apache.calcite.plan.SubstitutionVisitor$JoinOnCalcsToJoinUnifyRule.apply(SubstitutionVisitor.java:1446)
> at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:585)
> at org.apache.calcite.plan.SubstitutionVisitor.go(SubstitutionVisitor.java:519)
> at org.apache.calcite.test.MaterializedViewSubstitutionVisitorTest$1.optimize(MaterializedViewSubstitutionVisitorTest.java:94)
> at org.apache.calcite.test.MaterializedViewTester.checkMaterialize(MaterializedViewTester.java:78)
> at org.apache.calcite.test.MaterializedViewFixture.ok(MaterializedViewFixture.java:56)
> at org.apache.calcite.test.MaterializedViewSubstitutionVisitorTest.testJoinOnRightProjectToJoin(MaterializedViewSubstitutionVisitorTest.java:775){code}
> Field B.deptno is considered non-null in the join input but becomes nullable after the join, resulting in a type mismatch.
> Similar cases also occur in JoinOnRightCalcToJoinUnifyRule and JoinOnLeftCalcToJoinUnifyRule
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)