You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/01 04:51:03 UTC
[GitHub] [incubator-seatunnel] laglangyue opened a new pull request, #2588: [bug] fix flink-translate lost the dependency commons-io
laglangyue opened a new pull request, #2588:
URL: https://github.com/apache/incubator-seatunnel/pull/2588
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
the flink-v2-example will exec error, because it lost the dependency commons-io
and the dependency has in the file known-dependencies.txt.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2588: [bug] fix flink-translate lost the dependency commons-io
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2588:
URL: https://github.com/apache/incubator-seatunnel/pull/2588#issuecomment-1233740894
when I add the commons-io,it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2588: [bug] fix flink-translate lost the dependency commons-io
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2588:
URL: https://github.com/apache/incubator-seatunnel/pull/2588#issuecomment-1233827316
Please check dependencies list, if you add extra dependencies in project please add it in `know-denpencies.txt`. BTW, you can exeute `bash tools/dependencies/checkLicense.sh` in shell and check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue closed pull request #2588: [bug] fix flink-translate lost the dependency commons-io
Posted by GitBox <gi...@apache.org>.
laglangyue closed pull request #2588: [bug] fix flink-translate lost the dependency commons-io
URL: https://github.com/apache/incubator-seatunnel/pull/2588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2588: [bug] fix flink-translate lost the dependency commons-io
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2588:
URL: https://github.com/apache/incubator-seatunnel/pull/2588#issuecomment-1233742632
it't not need to add license,because it exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue closed pull request #2588: [bug] fix flink-translate lost the dependency commons-io
Posted by GitBox <gi...@apache.org>.
laglangyue closed pull request #2588: [bug] fix flink-translate lost the dependency commons-io
URL: https://github.com/apache/incubator-seatunnel/pull/2588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] laglangyue commented on pull request #2588: [bug] fix flink-translate lost the dependency commons-io
Posted by GitBox <gi...@apache.org>.
laglangyue commented on PR #2588:
URL: https://github.com/apache/incubator-seatunnel/pull/2588#issuecomment-1233740672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2588: [bug] fix flink-translate lost the dependency commons-io
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2588:
URL: https://github.com/apache/incubator-seatunnel/pull/2588#issuecomment-1234098300
Could you retest after updating the code? No clear log, but it's ok on my local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org