You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ivakegg (via GitHub)" <gi...@apache.org> on 2025/04/21 21:33:23 UTC

[PR] ACCUMULO-5489: The OOB check should be executed the first round through. [accumulo]

ivakegg opened a new pull request, #5493:
URL: https://github.com/apache/accumulo/pull/5493

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ACCUMULO-5489: The OOB check should be executed the first round through. [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed pull request #5493: ACCUMULO-5489: The OOB check should be executed the first round through.
URL: https://github.com/apache/accumulo/pull/5493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ACCUMULO-5489: The OOB check should be executed the first round through. [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5493:
URL: https://github.com/apache/accumulo/pull/5493#issuecomment-2821148578

   I applied this locally to build it, and this change causes test failures because the balance method exits early when tablets are out of bounds. The balance method returns an unexpected number of migrations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ACCUMULO-5489: The OOB check should be executed the first round through. [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #5493:
URL: https://github.com/apache/accumulo/pull/5493#issuecomment-2821654289

   I have included a fix for this in #5492. Instead of using `0` as the default value, I instead changed `getOrDefault` to `computeIfAbsent`. `getOrDefault` doesn't put the value into the map, so in this case the value would always be zero and the out of bounds check would always be performed regardless of the out of bound property value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ACCUMULO-5489: The OOB check should be executed the first round through. [accumulo]

Posted by "ivakegg (via GitHub)" <gi...@apache.org>.
ivakegg commented on PR #5493:
URL: https://github.com/apache/accumulo/pull/5493#issuecomment-2821252355

   > I applied this locally to build it, and this change causes test failures because the balance method exits early when tablets are out of bounds. The balance method returns an unexpected number of migrations.
   
   I had not gotten past figuring out what needed to be done to get this working operationally.  May I hand this off to you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org