You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2024/03/19 23:55:20 UTC
[impala-udf-samples-CR] Resolve linker errors due to uda-sample-test & udf-sample-test
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21170
Change subject: Resolve linker errors due to uda-sample-test & udf-sample-test
......................................................................
Resolve linker errors due to uda-sample-test & udf-sample-test
Updated make file to link uda-sample-test & udf-sample-test
properly.
Also, updated the default Impala UDF shared library name to
ImpalaUdf-retail.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/impala-udf-samples refs/changes/70/21170/1
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Aug 2025 16:34:03 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
This should have a JIRA ticket.
http://gerrit.cloudera.org:8080/#/c/21170/5/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/21170/5/README.md@6
PS5, Line 6: 4.5.0.x or higher is supported.
nit: not sure what the x in 4.5.0.x is.
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Aug 2025 17:15:00 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Aug 2025 19:18:26 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
......................................................................
Patch Set 7: Verified+1
Compiled successfully on a personal Red Hat 9 (virtual) workstation, using the system-supplied Boost 1.75, CMake 3.26.5, GCC 11.5 and a recent Impala UDF devkit.
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:28:27 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 3: Code-Review+1
Could you add a Jira number to the commit message title?
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 09:52:20 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21170/3/udf-sample.cc
File udf-sample.cc:
http://gerrit.cloudera.org:8080/#/c/21170/3/udf-sample.cc@168
PS3, Line 168: }");
> Maybe we can remove this, it might be a bit confusing as the model has alre
Sure, I picked the example from Impala repo.
https://github.com/apache/impala/blob/master/be/src/udf_samples/udf-sample.cc#L53
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 16:56:13 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
Sorry for the -1, but I would really love to see the typo fixed in the commit message header. Feel free to ping me when I can remove it :)
http://gerrit.cloudera.org:8080/#/c/21170/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21170/6//COMMIT_MSG@7
PS6, Line 7: mising
nit: typo 'missing'
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Aug 2025 17:14:52 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sun, 22 Jun 2025 22:24:50 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (801) has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 4:
(4 comments)
Some minor fixes suggested.
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h
File udf-sample.h:
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h@75
PS4, Line 75: // symbol=ClassifyReviewsDefault';
I believe the opening ' character is missing for 'ClassifyReviewsDefault'.
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h@84
PS4, Line 84: // symbol=ClassifyReviews';
I believe the opening ' character is missing for 'ClassifyReviews'.
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc
File udf-sample.cc:
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc@167
PS4, Line 167: const StringVal api_key_jceks_secret("open-ai-key");
I believe this parameter should be ai_api_key_jceks_secret
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc@171
PS4, Line 171: context, endpoint, prompt, model, api_key_jceks_secret, params, options);
api_key_jceks_secret should be ai_api_key_jceks_secret
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 23:51:23 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Aug 2025 20:20:34 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21170/4/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/21170/4/README.md@a5
PS4, Line 5:
Maybe we mention that the sample needs to use SDK for Impala 4.5+
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 18:06:13 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 4:
Re "Could you add a Jira number to the commit message title?"
I'm not sure if we use a JIRA project for this repository? Should we use IMPALA Jiras?
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Apr 2025 18:06:22 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Aug 2025 23:00:26 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
This patch updates the Impala UDF shared library name to
ImpalaUdf-retail.
Added UDF samples for AI functions.
Updated README to remove old download link for SDK. Apache Impala or
Cloudera docs should have updated link for downloading SDK.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
---
M CMakeLists.txt
M README.md
M udf-sample.cc
M udf-sample.h
4 files changed, 53 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/impala-udf-samples refs/changes/70/21170/6
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
COmmit message header typo patched; carrying +2s from Jason & Michael
http://gerrit.cloudera.org:8080/#/c/21170/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21170/6//COMMIT_MSG@7
PS6, Line 7: missin
> nit: typo 'missing'
Done
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Aug 2025 17:18:11 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has removed a vote on this change.
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Removed Code-Review-1 by Laszlo Gaal <la...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Resolve linker errors due to mising ImpalaUdf library
This patch updates the Impala UDF shared library name to
ImpalaUdf-retail.
Added UDF samples for AI functions.
Updated README to remove old download link for SDK. Cloudera docs
should have updated link for downloading SDK.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
---
M CMakeLists.txt
M README.md
M udf-sample.cc
M udf-sample.h
4 files changed, 52 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/impala-udf-samples refs/changes/70/21170/4
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/21170/4/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/21170/4/README.md@a5
PS4, Line 5:
> Maybe we mention that the sample needs to use SDK for Impala 4.5+
Done
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h
File udf-sample.h:
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h@75
PS4, Line 75: // symbol='ClassifyReviewsDefault';
> I believe the opening ' character is missing for 'ClassifyReviewsDefault'.
Done
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h@84
PS4, Line 84: // symbol='ClassifyReviews';
> I believe the opening ' character is missing for 'ClassifyReviews'.
Done
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc
File udf-sample.cc:
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc@167
PS4, Line 167: const StringVal api_key_jceks_secret("open-ai-key");
> I believe this parameter should be ai_api_key_jceks_secret
This is a local variable so should be fine.
http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc@171
PS4, Line 171: context, endpoint, prompt, model, api_key_jceks_secret, params, options);
> api_key_jceks_secret should be ai_api_key_jceks_secret
This is a local variable and not impala flagfile option.
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Sun, 22 Jun 2025 03:21:58 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Resolve linker errors due to mising ImpalaUdf library
This patch updates the Impala UDF shared library name to
ImpalaUdf-retail.
Added UDF samples for AI functions.
Updated README to remove old download link for SDK. Cloudera docs
should have updated link for downloading SDK.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
---
M CMakeLists.txt
M README.md
M udf-sample.cc
M udf-sample.h
4 files changed, 52 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/impala-udf-samples refs/changes/70/21170/2
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 4:
Ah, okay, I didn't notice it was the impala-udf-samples project, sorry. On the other hand, I think it's still not a bad idea to use IMPALA tickets for commits here too.
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 09:08:05 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Aug 2025 22:36:29 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Aug 2025 11:02:39 +0000
Gerrit-HasComments: No
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Resolve linker errors due to mising ImpalaUdf library
This patch updates the Impala UDF shared library name to
ImpalaUdf-retail.
Added UDF samples for AI functions.
Updated README to remove old download link for SDK. Cloudera docs
should have updated link for downloading SDK.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
---
M CMakeLists.txt
M README.md
M udf-sample.cc
M udf-sample.h
4 files changed, 52 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/impala-udf-samples refs/changes/70/21170/3
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21170/3/udf-sample.cc
File udf-sample.cc:
http://gerrit.cloudera.org:8080/#/c/21170/3/udf-sample.cc@168
PS3, Line 168: , \"model\": \"gpt-4\"
Maybe we can remove this, it might be a bit confusing as the model has already been specified above.
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Apr 2025 12:43:19 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has uploaded a new patch set (#7) to the change originally created by Abhishek Rawat. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
......................................................................
IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
This patch updates the Impala UDF shared library name to
ImpalaUdf-retail.
Added UDF samples for AI functions.
Updated README to remove old download link for SDK. Apache Impala or
Cloudera docs should have updated link for downloading SDK.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
---
M CMakeLists.txt
M README.md
M udf-sample.cc
M udf-sample.h
4 files changed, 53 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/impala-udf-samples refs/changes/70/21170/7
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Patch Set 5:
(1 comment)
Updated commit message to use IMPALA project's JIRAs.
http://gerrit.cloudera.org:8080/#/c/21170/5/README.md
File README.md:
http://gerrit.cloudera.org:8080/#/c/21170/5/README.md@6
PS5, Line 6: 4.5.0.x or higher is supported.
> nit: not sure what the x in 4.5.0.x is.
The upstream udf-devel rpm will have Impala versions like `impala-udf-devel-4.5.0`, but the Cloudera's udf-devel rpms will have versions like `impala-udf-devel-4.5.0.2025.0.19.0-51`
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Aug 2025 19:26:06 +0000
Gerrit-HasComments: Yes
[impala-udf-samples-CR] IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
......................................................................
IMPALA-14360: Resolve linker errors due to missing ImpalaUdf library
This patch updates the Impala UDF shared library name to
ImpalaUdf-retail.
Added UDF samples for AI functions.
Updated README to remove old download link for SDK. Apache Impala or
Cloudera docs should have updated link for downloading SDK.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
Reviewed-on: http://gerrit.cloudera.org:8080/21170
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Laszlo Gaal <la...@cloudera.com>
---
M CMakeLists.txt
M README.md
M udf-sample.cc
M udf-sample.h
4 files changed, 53 insertions(+), 3 deletions(-)
Approvals:
Laszlo Gaal: Looks good to me, approved; Verified
Jason Fehr: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[impala-udf-samples-CR] Resolve linker errors due to mising ImpalaUdf library
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library
......................................................................
Resolve linker errors due to mising ImpalaUdf library
This patch updates the Impala UDF shared library name to
ImpalaUdf-retail.
Added UDF samples for AI functions.
Updated README to remove old download link for SDK. Cloudera docs
should have updated link for downloading SDK.
Change-Id: I703398294dd719818352d5070297a2f74decdeed
---
M CMakeLists.txt
M README.md
M udf-sample.cc
M udf-sample.h
4 files changed, 53 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/impala-udf-samples refs/changes/70/21170/5
--
To view, visit http://gerrit.cloudera.org:8080/21170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: impala-udf-samples
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed
Gerrit-Change-Number: 21170
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>