You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/27 11:56:14 UTC
[GitHub] [pulsar] MarvinCai opened a new pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
MarvinCai opened a new pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401
Fixes #9680
This change added tests and can be verified as follows:
Added unit test.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: yes
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-830782158
> > Does this configuration also take effect at the broker level? I can't find configuration `backlogQuotaDefaultLimitSecond` in broker.conf
>
> Probably need to pull latest mainline, the broker side change should be merged via this pr: #10093
In this PR, broker.conf does not include this option as well. Should we add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-836739422
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-829200600
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-834271572
@315157973
Yes it's a broker config, added to broker.conf and standalone.conf
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-836564272
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-830777824
> Does this configuration also take effect at the broker level? I can't find configuration `backlogQuotaDefaultLimitSecond` in broker.conf
Probably need to pull latest mainline, the broker size change should be merged via this pr: https://github.com/apache/pulsar/pull/10093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai edited a comment on pull request #10401: [CLI] Add support for setting time based limit on backlog quota with CLI.
Posted by GitBox <gi...@apache.org>.
MarvinCai edited a comment on pull request #10401:
URL: https://github.com/apache/pulsar/pull/10401#issuecomment-830777824
> Does this configuration also take effect at the broker level? I can't find configuration `backlogQuotaDefaultLimitSecond` in broker.conf
Probably need to pull latest mainline, the broker side change should be merged via this pr: https://github.com/apache/pulsar/pull/10093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org