[jira] [Commented] (HADOOP-8642) io.native.lib.available only controls zlib

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870652#comment-13870652 ] 

Hadoop QA commented on HADOOP-8642:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12622832/HADOOP-8642.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.io.compress.TestCodec
                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3431//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3431//console

This message is automatically generated.

> io.native.lib.available only controls zlib
> ------------------------------------------
>
>                 Key: HADOOP-8642
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8642
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Akira AJISAKA
>         Attachments: HADOOP-8642.patch
>
>
> Per core-default.xml {{io.native.lib.available}} indicates "Should native hadoop libraries, if present, be used" however it looks like it only affects zlib. Since we always load the native library this means we may use native libraries even if io.native.lib.available is set to false.
> Let's make the flag to work as advertised - rather than always load the native hadoop library we only attempt to load the library (and report that native is available) if this flag is set. Since io.native.lib.available defaults to true the default behavior should remain unchanged (except that now we wont actually try to load the library if this flag is disabled).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)