You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ba...@apache.org on 2007/02/17 09:41:20 UTC

svn commit: r508733 - /jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/LocaleUtilsTest.java

Author: bayard
Date: Sat Feb 17 00:41:20 2007
New Revision: 508733

URL: http://svn.apache.org/viewvc?view=rev&rev=508733
Log:
Fixing LANG-320. I modified the tests to only check that the listed languages and countries are contained in the result, not that they exactly equal the result

Modified:
    jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/LocaleUtilsTest.java

Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/LocaleUtilsTest.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/LocaleUtilsTest.java?view=diff&rev=508733&r1=508732&r2=508733
==============================================================================
--- jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/LocaleUtilsTest.java (original)
+++ jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/LocaleUtilsTest.java Sat Feb 17 00:41:20 2007
@@ -391,7 +391,10 @@
 
     //-----------------------------------------------------------------------
     /**
-     * Make sure the language by country is correct.
+     * Make sure the language by country is correct. It checks that 
+     * the LocaleUtils.languagesByCountry(country) call contains the 
+     * array of languages passed in. It may contain more due to JVM 
+     * variations.
      *
      * @param country
      * @param languages array of languages that should be returned
@@ -401,7 +404,6 @@
         List list2 = LocaleUtils.languagesByCountry(country);
         assertNotNull(list);
         assertSame(list, list2);
-        assertEquals(languages.length, list.size());
         //search through langauges
         for (int i = 0; i < languages.length; i++) {
             Iterator iterator = list.iterator();
@@ -438,7 +440,11 @@
 
     //-----------------------------------------------------------------------
     /**
-     * Make sure the country by language is correct.
+     * Make sure the country by language is correct. It checks that 
+     * the LocaleUtils.countryByLanguage(language) call contains the 
+     * array of countries passed in. It may contain more due to JVM 
+     * variations.
+     *
      *
      * @param language
      * @param countries array of countries that should be returned
@@ -448,7 +454,6 @@
         List list2 = LocaleUtils.countriesByLanguage(language);
         assertNotNull(list);
         assertSame(list, list2);
-        assertEquals(countries.length, list.size());
         //search through langauges
         for (int i = 0; i < countries.length; i++) {
             Iterator iterator = list.iterator();



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org