You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/15 16:08:58 UTC

[jira] [Commented] (IGNITE-4408) IndexingSpi support BinaryObjects

    [ https://issues.apache.org/jira/browse/IGNITE-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751747#comment-15751747 ] 

ASF GitHub Bot commented on IGNITE-4408:
----------------------------------------

GitHub user AMashenkov opened a pull request:

    https://github.com/apache/ignite/pull/1353

    IGNITE-4408: IndexingSpi supports BinaryObjects 

    Allow BinaryObjects to be passed to IndexinSpi implementation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-4408-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1353
    
----
commit b9f98d2db2cbfebdd353b3656a2f05de18b65bee
Author: Andrey V. Mashenkov <an...@gmail.com>
Date:   2016-12-14T16:44:05Z

    Fixed SpiQuery fails if GridQueryProcessor is disabled.

commit d6800754944004fdb354f6da2b31d5ea4e78d66a
Author: Andrey V. Mashenkov <an...@gmail.com>
Date:   2016-12-15T14:53:10Z

    Allow BinaryObjects pass to IndexingSpi.

----


> IndexingSpi support BinaryObjects
> ---------------------------------
>
>                 Key: IGNITE-4408
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4408
>             Project: Ignite
>          Issue Type: Improvement
>          Components: binary
>    Affects Versions: 1.8
>            Reporter: Andrew Mashenkov
>            Assignee: Andrew Mashenkov
>              Labels: easyfix, performance
>             Fix For: 2.0
>
>
> For now key and values is being deserialized before passing to IndexingSpi. This can cause performance issues in some cases and there is no way to change this behavior.
> It look like we should allow to avoid deserialization and pass BinaryObjects if keepBinary option is true as we do for CacheStore. 
> Also SpiQueries should nof fails then both IndexingSpi is configured and GridQueryIndexing is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)