You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "timtebeek (via GitHub)" <gi...@apache.org> on 2023/05/09 16:16:41 UTC
[GitHub] [maven-plugin-tools] timtebeek opened a new pull request, #214: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
timtebeek opened a new pull request, #214:
URL: https://github.com/apache/maven-plugin-tools/pull/214
Continuation of https://issues.apache.org/jira/browse/MNG-6825
Use this link to re-run the recipe: https://public.moderne.io/recipes/org.openrewrite.java.migrate.apache.commons.lang.IsNotEmptyToJdk?organizationId=QXBhY2hlIE1hdmVu
Review requested of @elharo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] elharo merged pull request #214: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #214:
URL: https://github.com/apache/maven-plugin-tools/pull/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #214: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #214:
URL: https://github.com/apache/maven-plugin-tools/pull/214#issuecomment-1540953862
Buit not gone from the POM, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] timtebeek commented on pull request #214: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #214:
URL: https://github.com/apache/maven-plugin-tools/pull/214#issuecomment-1540970621
> Buit not gone from the POM, no?
We're not at the stage yet where we have removed all methods of StringUtils, so we can't yet remove the dependency. See for instance https://github.com/apache/maven-plugin-tools/blob/73791dd14fab1f974bab6415b074835945336728/maven-script/maven-script-ant/src/main/java/org/apache/maven/script/ant/AntMojoWrapper.java#L209-L210
As requested I'm doing small individual (automated) changes, such that they are easier to review and merge, with less risk.
We hope to get to fully removing StringUtils soon, but feel free to help out either in an automated fashion, or by cleaning up what remains after the first few rounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org