You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/01/07 11:27:49 UTC
[GitHub] incubator-brooklyn pull request: [WIP] Pluggable YAML parsers
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/436
[WIP] Pluggable YAML parsers
Rebases https://github.com/apache/incubator-brooklyn/pull/100 against master (as of beginning of December). The updates are needed for the TOSCA implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn refactor-camp-dependencies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/436.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #436
----
commit 55305ea9bf05598a8ac2c811691008818edbf321
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-11-28T15:30:05Z
Encapsulate all CAMP calls in a single place. Remove code repetition.
Parsing of CAMP specs goes through EntityManagementUtils for non-camp projects.
commit da4e1e060997148a54ec1ec654928770c848b450
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-12-01T11:04:19Z
Create a PlanToSpec provider for CAMP.
Move all CAMP-related functionality from core into brooklyn-camp. Core doesn't know the specifics of plan providers now.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] Pluggable YAML parsers
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/436#issuecomment-85279282
# Question
Is there a way to extend this with a mechanism to enable pluggable _extensions_ to YAML parsers. For example, I am happy with using the CAMP parser, but I want to allow the YAML files to be able to include service types like `docker:`_imageId_`:`_tag_ instead of Java class names. The parsing would be part of an external library, in this instance [Clocker](http://clocker.io/), since the entities created for these service types would be defined there, and core Brooklyn has no way of referencing the classes driectly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] Pluggable YAML parsers
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/436#issuecomment-69004221
Failure unrelated, merge conflict resolving needed anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] Pluggable YAML parsers
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/436#issuecomment-85410397
This should be easy to achieve using the same approach (ServiceLoader), by replacing the hard-coded resolvers in `io.brooklyn.camp.brooklyn.spi.creation.BrooklynComponentTemplateResolver.Factory.computeResolverType`. It's unrelated to this PR though as it's on another level of abstraction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] Pluggable YAML parsers
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/436#issuecomment-123338023
Closing in favour of https://github.com/apache/incubator-brooklyn/pull/760.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] Pluggable YAML parsers
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/436#issuecomment-103012866
@ahgittin do you think we should try to rebase this PR? I guess for things like TOSCA may really be the way to go? Any suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [WIP] Pluggable YAML parsers
Posted by neykov <gi...@git.apache.org>.
Github user neykov closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/436
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---