You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2011/07/25 23:53:12 UTC

Review Request: HIVE-2298. Fix UDAFPercentile to tolerate null percentiles

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1189/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Review request for HIVE-2298.


This addresses bug HIVE-2298.
    https://issues.apache.org/jira/browse/HIVE-2298


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java 92db544 

Diff: https://reviews.apache.org/r/1189/diff


Testing
-------


Thanks,

Carl

Re: Review Request: HIVE-2298. Fix UDAFPercentile to tolerate null percentiles

Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1189/#review1181
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java
<https://reviews.apache.org/r/1189/#comment2483>

    Please fix the following checkstyle violations:
    
    Line 238: File contains tab characters (this is the first instance).
    Line 240: is longer than 100 characters.
    Line 245: '}' should be on the same line.


- Carl


On 2011-07-25 21:53:12, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1189/
> -----------------------------------------------------------
> 
> (Updated 2011-07-25 21:53:12)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Review request for HIVE-2298.
> 
> 
> This addresses bug HIVE-2298.
>     https://issues.apache.org/jira/browse/HIVE-2298
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java 92db544 
> 
> Diff: https://reviews.apache.org/r/1189/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>