You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/08 10:03:39 UTC

[GitHub] [pulsar] anvinjain opened a new issue #7481: Default value and in-line doc for bookkeeper config: openLedgerRereplicationGracePeriod is incorrect

anvinjain opened a new issue #7481:
URL: https://github.com/apache/pulsar/issues/7481

**Describe the bug**
Default bookkeeper conf that ships with apache pulsar indicates that the unit of `openLedgerRereplicationGracePeriod` is in seconds, but official bookkeeper doc(and code) mentions that the unit is in milliseconds. Since default is 30seconds, this will be interpreted by BK as 30ms

**To Reproduce**
Steps to reproduce the behavior:
1. Go to https://bookkeeper.apache.org/docs/4.10.0/reference/config/ and read documentation for openLedgerRereplicationGracePeriod. It clearly mentions that the period is in milliseconds and default is 30000. This can be further confirmed by seeing usage of grace period in https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java where it is treated as milliseconds
1. Download apache pulsar release (checked in 2.5.2 and 2.6.0) or go here: https://github.com/apache/pulsar/blob/master/conf/bookkeeper.conf
1. Observe that openLedgerRereplicationGracePeriod=30 is configured and comments above this mention that the period is in seconds
1. Pulsar will end up configuring grace period as 30ms which is not the expected behaviour (30s is expected)

**Expected behavior**
Pulsar should configure default as 30000 instead of 30 and bookkeeper.conf should mention that the unit of this period is milliseconds instead of seconds.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: Debian 9

**Additional context**
Add any other context about the problem here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on issue #7481: Default value and in-line doc for bookkeeper config: openLedgerRereplicationGracePeriod is incorrect

Posted by GitBox <gi...@apache.org>.

codelipenghui commented on issue #7481:
URL: https://github.com/apache/pulsar/issues/7481#issuecomment-657306782


   @anvinjain Thanks for the feedback, are you interested in pushing a fix for it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai closed issue #7481: Default value and in-line doc for bookkeeper config: openLedgerRereplicationGracePeriod is incorrect

Posted by GitBox <gi...@apache.org>.

jiazhai closed issue #7481:
URL: https://github.com/apache/pulsar/issues/7481


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] anvinjain commented on issue #7481: Default value and in-line doc for bookkeeper config: openLedgerRereplicationGracePeriod is incorrect

Posted by GitBox <gi...@apache.org>.

anvinjain commented on issue #7481:
URL: https://github.com/apache/pulsar/issues/7481#issuecomment-658013060


   @codelipenghui Sure, I will take this up. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org