You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/06 22:13:09 UTC

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #745: arch/stm32h7: Explicit support for all STM32H7x3xx

hartmannathan opened a new pull request #745: arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745
 
 
   All parts in the STM32H7x3xx family have the same pinmap, etc.,
   so extending support to all members of the family required only
   minimal changes: Adding them to Kconfig and extending some
   preprocessor logic.
   
   arch/arm/src/stm32h7/Kconfig:  Add explicit support for all
   microcontrollers in the STM32H7x3xx family by adding support for:
       * STM32H743AG
       * STM32H743AI
       * STM32H743BG
       * STM32H743BI
       * STM32H743IG
       * STM32H743II
       * STM32H743VG
       * STM32H743VI
       * STM32H743XG
       * STM32H743XI
       * STM32H743ZG
       * STM32H753AI
       * STM32H753BI
       * STM32H753VI
       * STM32H753XI
       * STM32H753ZI
   
   arch/arm/include/stm32h7/chip.h:  Extend preprocessor logic to
   add support for the new microcontrollers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408482642
 
 

 ##########
 File path: arch/arm/src/stm32h7/stm32_gpio.c
 ##########
 @@ -162,6 +162,20 @@ int stm32_configgpio(uint32_t cfgset)
       return -EINVAL;
     }
 
+#if (STM32H7_NGPIO > 5) && (!defined(CONFIG_STM32H7_HAVE_GPIOF))
 
 Review comment:
   I can init g_gpiobase[5] and g_gpiobase[6] to 0 and check for that every place g_gpiobase[] is used. Will that be acceptable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r407471765
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @hartmannathan - what part number are you referring to? Is H just the OSC?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613087210
 
 
   > Nathan, didn't you merge your branch back to your local master before rebasing?
   > The old commit "[c9fd5bb](https://github.com/hartmannathan/incubator-nuttx/commit/c9fd5bb35d70b9bd320023de9d46592b4d3e3999)" is still in your history.
   > Rebase the branch interactively and drop it.
   > `git rebase -i HEAD~2`
   
   I've been doing all my work on branches, not working on my local master at all. I've been tracking the upstream master in my local master. That is why I didn't merge back to my local master first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614776219
 
 
   > @hartmannathan LGTM, on minor nit. The idea is to tell a user what CONFIG_xxxx to set not what it means. With this approach the user can grep for it. The other is in someones head at the time of development.
   
   Thank you for all your efforts, help, and reviews!
   
   I'll go ahead and remove "Do Not Merge" from the title. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408480970
 
 

 ##########
 File path: arch/arm/src/stm32h7/Kconfig
 ##########
 @@ -289,13 +468,13 @@ config STM32H7_ETHMAC
 	select ARCH_HAVE_PHY
 
 config STM32H7_FMC
-        bool "FMC"
-        default n
-        depends on STM32H7_HAVE_FMC
-        ---help---
-                Enable Flexible Memory Controller.
-                To correctly configure FMC for your hardware, you will have to define
-                a number of macros in your board.h file. See stm32_fmc.c for directions.
+		bool "FMC"
 
 Review comment:
   Good catch. Fixed in 8e861dfe6093.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408316538
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   Commit 1dd150b ("stm32h7: Handle missing GPIO ports F and G on 100-pin parts") adds this handling. Could you please review the changes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r407267427
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @davids5 How would you define STM32H7_NGPIO if there are gaps in the ports? For example, if ports A, B, C, D, E, H are exposed to pins, and ports F and G are not exposed to pins, is STM32H7_NGPIO supposed to be defined to 6 or 8?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614245708
 
 
   @haitao20020347 Please feel free to rebase -i and force push. Then can review it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408494579
 
 

 ##########
 File path: arch/arm/src/stm32h7/stm32_gpio.c
 ##########
 @@ -162,6 +162,20 @@ int stm32_configgpio(uint32_t cfgset)
       return -EINVAL;
     }
 
+#if (STM32H7_NGPIO > 5) && (!defined(CONFIG_STM32H7_HAVE_GPIOF))
 
 Review comment:
   I made this change in commit 7d70abc4d4a1. Because g_gpiobase[5] and g_gpiobase[6] is initted to 0, a null check is now required in stm32_gpioread() and stm32_gpiowrite(). I added those and fixed resulting nxstyle complaints.
   
   Waiting to hear your thoughts... Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #745: arch/stm32h7: Extend support to all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #745: arch/stm32h7: Extend support to all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408173664
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   Yes, in all the STM32H7x3xx, PH0 and PH1 have only one alternate function: AF15, EVENTOUT. And, these pins can be GPIOs if not used for the OSC.
   
   So, which of the following would you prefer?
   
   - **STM32H7_NGPIO** defined to 6 (GPIOA thru GPIOF) and ignore GPIOH, or
   - **STM32H7_NGPIO** defined to 8 (GPIOA thru GPIOH), and add a **CONFIG_STM32H7_HAVE_GPIOG** to Kconfig.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614773382
 
 
   @hartmannathan - do you want to rebase and force push or shall I just squash it.?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614301248
 
 
   One sec... I have to fix the nxstyle complaints and re-squash...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614290627
 
 
   > > @hartmannathan if you wrap https://github.com/hartmannathan/incubator-nuttx/blob/stm32h7x3xx/arch/arm/src/stm32h7/stm32_gpio.h#L203-L204 - With the defined(CONFIG_STM32H7_HAVE_GPIO{GF}) Then compiler will keep a user from using Ports G and F on a part that does not support it.
   > 
   > Then it would make sense to wrap the other GPIO_PORTn defines with similar preprocessor logic, so that e.g., the compiler will prevent use of GPIO_PORTK when it doesn't exist. I'll make that change.
   
   Done in 3c633b6f5f.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r407680891
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @davids5 - any of the 100-pin "V" parts have this condition, e.g., STM32H743VITx. Yes, H is only PH0-OSC_IN, PH1-OSC_OUT. But in addition to oscillator, these pins can be GPIO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613095203
 
 
   > You must force the push, the history just changed.
   > git push -f origin stm32h7x3xx
   > (assuming "origin" is the remote name of the fork"
   
   Yes. That did it. Thanks for your help.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614776505
 
 
   > @hartmannathan - do you want to rebase and force push or shall I just squash it.?
   
   Sure, I can rebase it... I'll do that now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: arch/stm32h7: Extend support to all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: arch/stm32h7: Extend support to all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614850990
 
 
   On Thu, Apr 16, 2020 at 3:23 PM patacongo <no...@github.com> wrote:
   
   > Merged #745 <https://github.com/apache/incubator-nuttx/pull/745> into
   > master.
   >
   
   Thank you!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r407776951
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @davids5 - The latest commit I pushed to this PR fixes the TODO IO_CONFIG items in the STM32H7 Kconfig and defines STM32H7_NGPIO according to those IO_CONFIGs. Please give me your opinion on this.
   
   Also, as I mentioned before, the 100-pin IO_CONFIG_V parts have a gap in the port letters, it has GPIOA-GPIOH, but it's missing GPIOF-GPIOG. Should this be handled, and what would you recommend?
   
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614212264
 
 
   If there are no further concerns, I'd like to remove the "DO NOT MERGE" from the title. But first, I think I should squash the commits and write a better commit message, to make our lives easier when we begin to write the 9.1 Release Notes.
   
   Questions:
   
   (1) Any further concerns about the code?
   
   (2) Any reason not to squash the commits?
   
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: [Do Not Merge] arch/stm32h7: Extend support to all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r409686238
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -92,7 +116,22 @@
 
 /* Peripherals */
 
-#  define STM32H7_NGPIO                   (11)        /* GPIOA-GPIOK */
+#  if defined(CONFIG_STM32H7_IO_CONFIG_A)
+#      define STM32H7_NGPIO               (10)        /* GPIOA-GPIOJ */
+#  elif defined(CONFIG_STM32H7_IO_CONFIG_B)
+#      define STM32H7_NGPIO               (11)        /* GPIOA-GPIOK */
+#  elif defined(CONFIG_STM32H7_IO_CONFIG_I)
+#      define STM32H7_NGPIO               (9)         /* GPIOA-GPIOI */
+#  elif defined(CONFIG_STM32H7_IO_CONFIG_V)
+#      define STM32H7_NGPIO               (8)         /* GPIOA-GPIOH, missing GPIOF-GPIOG */
+#  elif defined(CONFIG_STM32H7_IO_CONFIG_X)
+#      define STM32H7_NGPIO               (11)        /* GPIOA-GPIOK */
+#  elif defined(CONFIG_STM32H7_IO_CONFIG_Z)
+#      define STM32H7_NGPIO               (8)         /* GPIOA-GPIOH */
+#  else
+#      error IO config not identified
 
 Review comment:
   ```suggestion
   #      error CONFIG_STM32H7_IO_CONFIG_x Not Set
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408474857
 
 

 ##########
 File path: arch/arm/src/stm32h7/Kconfig
 ##########
 @@ -289,13 +468,13 @@ config STM32H7_ETHMAC
 	select ARCH_HAVE_PHY
 
 config STM32H7_FMC
-        bool "FMC"
-        default n
-        depends on STM32H7_HAVE_FMC
-        ---help---
-                Enable Flexible Memory Controller.
-                To correctly configure FMC for your hardware, you will have to define
-                a number of macros in your board.h file. See stm32_fmc.c for directions.
+		bool "FMC"
 
 Review comment:
   This block looks to be indented wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613053829
 
 
   > @hartmannathan - I think you wanted to rebase and force push?
   > 
   > git reset --hard the commit befoe the mess.
   > git fetch APPACHE_REMOTE
   > git rebase APPACHE_REMOTE/master
   > git push -f THIS REMOTE branch name
   
   I did rebase, and pushed without force. The difference is that I synced my fork to upstream with:
   
   Sometime previously:
   git remote add upstream https://github.com/apache/incubator-nuttx.git
   
   Today:
   git fetch upstream
   git checkout master
   git rebase upstream/master
   git push origin
   
   Then I rebased my stm32h7x3xx branch onto my updated master with:
   
   git checkout stm32h7x3xx
   git rebase master
   git push
   
   I'm not sure why, the rebase produced a merge commit. So now it's showing a bunch of unrelated commits as part of this PR. That's totally messed up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613158917
 
 
   I'm not sure why the tests are failing.
   
   On my system, I was able to build the **stm32h747i-disco:nsh** and **nucleo-h743zi:nsh** configs successfully.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-611240620
 
 
   @hartmannathan - Thank you! Ping me if you need any thing!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 edited a comment on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614245708
 
 
   @haitao20020347 Please feel free to rebase -i and force push. Then can review it.
   
   Opps meant @hartmannathan not haitao20020347

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613029749
 
 
   @hartmannathan - I think you wanted to rebase and force push?
   
   
   git reset --hard the commit befoe the mess.
   git  fetch APPACHE_REMOTE
   git rebase APPACHE_REMOTE/master
   git push -f THIS REMOTE branch name
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan edited a comment on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan edited a comment on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-611182808
 
 
   I'd like to mark this PR as "Do Not Merge" for now. I'm working on addressing this but it will be a few days.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408217514
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   I think the CONFIG_STM32H7_HAVE_GPIOx solution is good way to go, but to catch it at compile time, the CONFIG_STM32H7_HAVE_GPIOx will have to wrapped in the #if defined(CONFIG_STM32H7_HAVE_GPIOx). From the run time side, the table could be set to null and an error returned. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613090231
 
 
   Actually even a plain rebase will drop the old commit "dropping c9fd5bb35d70b9bd320023de9d46592b4d3e3999 arch/stm32h7: Explicit support for all STM32H7x3xx -- patch contents already upstream" no need to do it manually. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614248228
 
 
   @hartmannathan if you wrap https://github.com/hartmannathan/incubator-nuttx/blob/stm32h7x3xx/arch/arm/src/stm32h7/stm32_gpio.h#L203-L204 -  With the  defined(CONFIG_STM32H7_HAVE_GPIO{GF}) Then compiler will keep a user from using Ports G and F on a part that does not support it. 
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613085594
 
 
   Nathan, didn't you merge your branch back to your local master before rebasing?
   The old commit "[c9fd5bb](https://github.com/hartmannathan/incubator-nuttx/commit/c9fd5bb35d70b9bd320023de9d46592b4d3e3999)" is still in your history.
   Rebase the branch interactively and drop it.
   `git rebase -i HEAD~2`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 edited a comment on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613092792
 
 
   You must force the push, the history just changed.
   git push -f origin stm32h7x3xx
   (assuming "origin" is the remote name of the fork"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #745: arch/stm32h7: Extend support to all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #745: arch/stm32h7: Extend support to all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614848336
 
 
   > I'll go ahead and remove "Do Not Merge" from the title. :-)
   
   I presume this means that it is ready to be merged?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-614284278
 
 
   > @hartmannathan if you wrap https://github.com/hartmannathan/incubator-nuttx/blob/stm32h7x3xx/arch/arm/src/stm32h7/stm32_gpio.h#L203-L204 - With the defined(CONFIG_STM32H7_HAVE_GPIO{GF}) Then compiler will keep a user from using Ports G and F on a part that does not support it.
   
   Then it would make sense to wrap the other GPIO_PORTn defines with similar preprocessor logic, so that e.g., the compiler will prevent use of GPIO_PORTK when it doesn't exist. I'll make that change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613092792
 
 
   You must force the push, the history just changed.
   git push -f origin stm32h7x3xx

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613160427
 
 
   
   > I'm not sure why the tests are failing.
   > 
   > On my system, I was able to build the **stm32h747i-disco:nsh** and **nucleo-h743zi:nsh** configs successfully.
   
   You can see the errors in the logs available through the "Details" link to the right of the failed test.  This is the failure for arm-13:
   
        /usr/bin/docker: error pulling image configuration: received unexpected HTTP status: 504 Gateway Timeout.
   
   I would restart the checks.  Go to the Checks tab and if the test is not running, you can restart with the button on the right.  I will restart now.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408069455
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @hartmannathan - 
   
   
   ![image](https://user-images.githubusercontent.com/1945821/79220829-9d794f80-7e09-11ea-82cd-6ecc48113b75.png)
   
   I would think the RCC sets up the OSC is enabled and From the above, If I have the correct datasheet I do not see any AF0-14 for PH0 and 1, 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408069455
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @hartmannathan - 
   
   
   ![image](https://user-images.githubusercontent.com/1945821/79220829-9d794f80-7e09-11ea-82cd-6ecc48113b75.png)
   
   I would think the RCC sets up the OSC it if is enabled and from the above,( If I have the correct datasheet) I do not see any AF0-14 for PH0 and 1, 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-610092770
 
 
   > @hartmannathan -
   > 
   > This does not address the IO limitations. So without the IO setting added, what is the value of this over the selection of the flash size in Kconfig?
   
   @davids5 
   
   Where is that addressed? I saw "REVISIT" comments so my impression was that none of the other configs are doing that, but please tell me if I missed something.
   
   Also, the reason for adding these configs is that I need to do a project with one of them; the effort to add them all is essentially the same as the effort to add just the one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r405741075
 
 

 ##########
 File path: arch/arm/include/stm32h7/chip.h
 ##########
 @@ -53,16 +53,40 @@
  *
  *   PART        PACKAGE
  *   ----------- ----------------
+ *   STM32H7x3Ax UFBGA169
 
 Review comment:
   @hartmannathan 
   
   > Where is that addressed?
   
   Grep for STM32H7_NGPIO then look at the F7 and follow the pattern.
   
   For the package with different pin counts we do not want to make something that is not whole appear to be.  Or said another way: A problem found at compile time is much better then one found in the debugger.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-611182808
 
 
   I'd like to mark this PR as "Do Not Merge" for now. I'm working on addressing this but it will be a few days.
   
   > On Apr 8, 2020, at 2:51 PM, David Sidrane <no...@github.com> wrote:
   > 
   > 
   > @davids5 requested changes on this pull request.
   > 
   > @hartmannathan See inline
   > 
   > In arch/arm/include/stm32h7/chip.h:
   > 
   > > @@ -53,16 +53,40 @@
   >   *
   >   *   PART        PACKAGE
   >   *   ----------- ----------------
   > + *   STM32H7x3Ax UFBGA169
   > @hartmannathan
   > 
   > Where is that addressed?
   > 
   > Grep for STM32H7_NGPIO then look at the F7 and follow the pattern.
   > 
   > For the package with different pin counts we do not want to make something that is not whole appear to be. Or said another way: A problem found at compile time is much better then one found in the debugger.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408475913
 
 

 ##########
 File path: arch/arm/src/stm32h7/stm32_gpio.c
 ##########
 @@ -162,6 +162,20 @@ int stm32_configgpio(uint32_t cfgset)
       return -EINVAL;
     }
 
+#if (STM32H7_NGPIO > 5) && (!defined(CONFIG_STM32H7_HAVE_GPIOF))
 
 Review comment:
   Can all this be just a null check on line 181?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx
URL: https://github.com/apache/incubator-nuttx/pull/745#issuecomment-613092068
 
 
   > Actually even a plain rebase will drop the old commit "dropping [c9fd5bb](https://github.com/apache/incubator-nuttx/commit/c9fd5bb35d70b9bd320023de9d46592b4d3e3999) arch/stm32h7: Explicit support for all STM32H7x3xx -- patch contents already upstream" no need to do it manually.
   
   Nope.
   
   It can remove that commit, but not push it:
   
   To https://github.com/hartmannathan/incubator-nuttx.git
    ! [rejected]              stm32h7x3xx -> stm32h7x3xx (non-fast-forward)
   error: failed to push some refs to 'https://github.com/hartmannathan/incubator-nuttx.git'
   hint: Updates were rejected because the tip of your current branch is behind
   hint: its remote counterpart. Integrate the remote changes (e.g.
   hint: 'git pull ...') before pushing again.
   hint: See the 'Note about fast-forwards' in 'git push --help' for details.
   
   Attempting to git pull results in a merge commit, which will cause the above mess.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services