You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Enrico Olivelli (JIRA)" <ji...@apache.org> on 2019/04/13 20:18:00 UTC
[jira] [Commented] (MCHECKSTYLE-366) Upgrade checkstyle to a more
recent version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817076#comment-16817076 ]
Enrico Olivelli commented on MCHECKSTYLE-366:
---------------------------------------------
I am working on this, I want to fix this before cutting a release, currently I have these failures:
[ERROR] The following builds failed:
[ERROR] * MCHECKSTYLE-137/pom.xml
[ERROR] * MCHECKSTYLE-169/pom.xml
[ERROR] * MCHECKSTYLE-338/pom.xml
[ERROR] * MCHECKSTYLE-193/pom.xml
[ERROR] * multi-modules-aggregate/pom.xml
[ERROR] * MCHECKSTYLE-129/pom.xml
> Upgrade checkstyle to a more recent version
> -------------------------------------------
>
> Key: MCHECKSTYLE-366
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-366
> Project: Maven Checkstyle Plugin
> Issue Type: Dependency upgrade
> Affects Versions: 3.0.0
> Reporter: Olivier Grégoire
> Assignee: Enrico Olivelli
> Priority: Major
>
> Version 3.0.0 still uses checkstyle 6.18.
>
> The google_checks.xml of 6.18 contains a rule that says "com.google" imports must be first. This was [removed in 2016|https://github.com/checkstyle/checkstyle/commit/81ad4595fe3a916551d73e467044c87d8462dba6#diff-c55cd603ef6597463971db3f33f4f4c8] yet the latest version of checkstyle (3.0.0 of January 2018) still says I should use that version of 2016 which has the dummy rule that com.google imports should come first.
>
> I know it's overridable, but the bottom line is that checkstyle relies on an really outdated version of checkstyle which has total nonsense in it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)