You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/28 15:42:13 UTC
[GitHub] [arrow] lidavidm opened a new pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
lidavidm opened a new pull request #12284:
URL: https://github.com/apache/arrow/pull/12284
Prevent us from mixing system/bundled gRPC and Protobuf, since gRPC itself links to Protobuf and having two copies of Protobuf linked will lead to runtime errors or crashes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024342666
For many of the Crossbow builds, this should have the effect of bundling both Protobuf and gRPC, since the system Protobuf is too old to support Flight/Flight SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024732280
Benchmark runs are scheduled for baseline = f92219d05e0255157f628baa445824a96ff94ada and contender = ed3113b8bd286b8cf29b1d349fa9f3444706347c. ed3113b8bd286b8cf29b1d349fa9f3444706347c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48a1b684f6f74b1f8270b5ec34aa74d1...ab8df1413aac4802a9b7c288f1292fe3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4201d0e3e06c419aa776e09fb739819e...4fd611594aa14c5b8a802498a9b51be9/)
[Finished :arrow_down:0.22% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8c95fb8fe44f4e67824b020110658a70...971c03ef715f411ca7e5a1d24e7766fa/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024678085
Revision: 72a0146c399898d66fbaeaf14c73adb1ba6e4b31
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1532](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1532)
|Task|Status|
|----|------|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1532-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #12284:
URL: https://github.com/apache/arrow/pull/12284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024732280
Benchmark runs are scheduled for baseline = f92219d05e0255157f628baa445824a96ff94ada and contender = ed3113b8bd286b8cf29b1d349fa9f3444706347c. ed3113b8bd286b8cf29b1d349fa9f3444706347c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48a1b684f6f74b1f8270b5ec34aa74d1...ab8df1413aac4802a9b7c288f1292fe3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4201d0e3e06c419aa776e09fb739819e...4fd611594aa14c5b8a802498a9b51be9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8c95fb8fe44f4e67824b020110658a70...971c03ef715f411ca7e5a1d24e7766fa/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024341354
https://issues.apache.org/jira/browse/ARROW-15495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024684702
@github-actions crossbow submit test-ubuntu-21.04-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024352290
> Did you manage to reproduce it with `UBUNTU=21.04 archery docker run ubuntu-cpp`?
I will give that a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm edited a comment on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
lidavidm edited a comment on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024348698
CC @kszucs @kou, I originally had it raise an error, but this is less disruptive. I checked that the tests indeed fail on Ubuntu 21.04 when you mix the two, and that they pass when both are bundled. I couldn't test when both dependencies came from the system, since Protobuf is too old. I also couldn't replicate under Conda, because grpc-cpp includes CMake files instead of pkg-config files which then call FindProtobuf and throw a different error if you try to mix the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024469255
Sorry for the delay. It indeed fails with
> env UBUNTU=21.04 PYTHONPATH=./dev/archery:(pwd) python -m archery.cli docker run -e "ARROW_FLIGHT=ON" -e "ARROW_FLIGHT_SQL=ON" -e "Protobuf_SOURCE=BUNDLED" ubuntu-cpp
I had to update a dockerfile:
```
diff --git a/ci/docker/ubuntu-21.04-cpp.dockerfile b/ci/docker/ubuntu-21.04-cpp.dockerfile
index 58639cb1c..595776a8a 100644
--- a/ci/docker/ubuntu-21.04-cpp.dockerfile
+++ b/ci/docker/ubuntu-21.04-cpp.dockerfile
@@ -85,6 +85,7 @@ RUN apt-get update -y -q && \
libprotoc-dev \
libre2-dev \
libsnappy-dev \
+ libsqlite3-dev \
libssl-dev \
libthrift-dev \
libutf8proc-dev \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024732280
Benchmark runs are scheduled for baseline = f92219d05e0255157f628baa445824a96ff94ada and contender = ed3113b8bd286b8cf29b1d349fa9f3444706347c. ed3113b8bd286b8cf29b1d349fa9f3444706347c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48a1b684f6f74b1f8270b5ec34aa74d1...ab8df1413aac4802a9b7c288f1292fe3/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4201d0e3e06c419aa776e09fb739819e...4fd611594aa14c5b8a802498a9b51be9/)
[Finished :arrow_down:0.22% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8c95fb8fe44f4e67824b020110658a70...971c03ef715f411ca7e5a1d24e7766fa/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024686066
Revision: 95855a5138adaa6184d399d470fbd65ea1893065
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1534](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1534)
|Task|Status|
|----|------|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1534-github-test-r-ubuntu-21.04)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1534-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024685329
@github-actions crossbow submit *21.04*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024685384
Revision: 95855a5138adaa6184d399d470fbd65ea1893065
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1533](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1533)
|Task|Status|
|----|------|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1533-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024642661
Thanks David! I'm going to add that and also register it as a nightly job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024350939
> I originally had it raise an error, but this is less disruptive.
My first thought was to raise too, but this looks like a better way to handle it.
> I checked that the tests indeed fail on Ubuntu 21.04 when you mix the two, and that they pass when both are bundled. I couldn't test when both dependencies came from the system, since Protobuf is too old.
Did you manage to reproduce it with `UBUNTU=21.04 archery docker run ubuntu-cpp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024348698
CC @kszucs @kou, I originally had it raise an error, but this is less disruptive. I checked that the tests indeed fail on Ubuntu 21.04 when you mix the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024676082
@github-actions crossbow submit test-ubuntu-21.04-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024732280
Benchmark runs are scheduled for baseline = f92219d05e0255157f628baa445824a96ff94ada and contender = ed3113b8bd286b8cf29b1d349fa9f3444706347c. ed3113b8bd286b8cf29b1d349fa9f3444706347c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/48a1b684f6f74b1f8270b5ec34aa74d1...ab8df1413aac4802a9b7c288f1292fe3/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4201d0e3e06c419aa776e09fb739819e...4fd611594aa14c5b8a802498a9b51be9/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8c95fb8fe44f4e67824b020110658a70...971c03ef715f411ca7e5a1d24e7766fa/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #12284: ARROW-15495: [C++][FlightRPC] Require Protobuf/gRPC SOURCEs to match
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #12284:
URL: https://github.com/apache/arrow/pull/12284#issuecomment-1024350939
> I originally had it raise an error, but this is less disruptive.
My first thought was to raise too, but this looks like a better way to handle it.
> I checked that the tests indeed fail on Ubuntu 21.04 when you mix the two, and that they pass when both are bundled. I couldn't test when both dependencies came from the system, since Protobuf is too old.
Did you manage to reproduce it with `UBUNTU=21.04 archery docker run ubuntu-cpp`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org