You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2024/12/10 11:09:17 UTC
[PR] [MINOR] test: Fix ConcurrentModifiedException while use TestAppender [incubator-uniffle]
maobaolong opened a new pull request, #2285:
URL: https://github.com/apache/incubator-uniffle/pull/2285
### What changes were proposed in this pull request?
Fix ConcurrentModifiedException while use TestAppender
### Why are the changes needed?
```
[ERROR] testNewAppWhileCheckLeak{ExtensionContext} Time elapsed: 0.3 s <<< ERROR!
java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:911)
at java.util.ArrayList$Itr.next(ArrayList.java:861)
at org.apache.uniffle.common.log.TestLoggerExtension$TestAppender.wasLogged(TestLoggerExtension.java:106)
at org.apache.uniffle.common.log.TestLoggerExtension.wasLogged(TestLoggerExtension.java:73)
at org.apache.uniffle.server.storage.LocalStorageManagerTest.testNewAppWhileCheckLeak(LocalStorageManagerTest.java:399)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] test: Fix ConcurrentModifiedException while use TestAppender [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2285:
URL: https://github.com/apache/incubator-uniffle/pull/2285#issuecomment-2531278890
Could you commit this to branch-0.10, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] test: Fix ConcurrentModifiedException while use TestAppender [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2285:
URL: https://github.com/apache/incubator-uniffle/pull/2285#issuecomment-2533397891
https://github.com/apache/incubator-uniffle/pull/2286 @jerqi Here it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] test: Fix ConcurrentModifiedException while use TestAppender [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2285:
URL: https://github.com/apache/incubator-uniffle/pull/2285#issuecomment-2531318108
## Test Results
2 966 files +23 2 966 suites +23 6h 28m 16s ⏱️ + 9m 18s
1 096 tests ± 0 1 094 ✅ + 1 2 💤 ±0 0 ❌ - 1
13 735 runs +53 13 705 ✅ +54 30 💤 ±0 0 ❌ - 1
Results for commit 2e0ffda1. ± Comparison against base commit 0552d3b0.
[test-results]:data:application/gzip;base64,H4sIAGwnWGcC/02MSw6DMAwFr4Ky7sLEMYRepqIhlqICqfJZVb17w6fAcsbP8xHsRhvFvZJd09wqEbNLVx5y6JPz82KwuKLKPS2LGk58xGzM5tTpXu69/B2CezcWAYewIfiwm5DntYot0o5HFVs43VbF/8+1uvI1avw0uVRASAvMQ18PqFkBAdXWEtNTApI2RjVYBlp34vsDkZSH9BQBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] test: Fix ConcurrentModifiedException while use TestAppender [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong merged PR #2285:
URL: https://github.com/apache/incubator-uniffle/pull/2285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org