[jira] [Commented] (ARROW-12805) [Python] Use consistent memory_pool / pool keyword argument name

["David Li (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346108#comment-17346108 ] 

David Li commented on ARROW-12805:
----------------------------------

Note this isn't even all that consistent in C++; there's no keyword arguments of course, but while it's usually just {{pool}}, it seems some of the dataset/compute code calls it {{memory_pool}} in places like getters.

> [Python] Use consistent memory_pool / pool keyword argument name
> ----------------------------------------------------------------
>
>                 Key: ARROW-12805
>                 URL: https://issues.apache.org/jira/browse/ARROW-12805
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Joris Van den Bossche
>            Priority: Minor
>             Fix For: 5.0.0
>
>
> Most of the functions taking a MemoryPool have a {{memory_pool}} keyword for this, but a few take a {{pool}} keyword instead (eg {{ListArray.from_arrays}}). 
> We should make this consistent and have all functions use {{memory_pool}} (probably best with deprecating {{pool}} first). 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)