You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/04 22:19:22 UTC
[GitHub] [spark] maryannxue opened a new pull request #27799:
[SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
maryannxue opened a new pull request #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799
### What changes were proposed in this pull request?
This PR avoids sending redundant metrics (those that have been included in previous update) to Spark UI in AQE UI metrics update.
### Why are the changes needed?
This change will make UI metrics update more efficient.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Manual test in Spark UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27799:
[SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594892093
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24080/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27799: [SPARK-31046][SQL]
Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27799: [SPARK-31046][SQL]
Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594892073
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27799:
[SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594892073
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27799: [SPARK-31046][SQL] Make
more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594996568
**[Test build #119343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119343/testReport)** for PR 27799 at commit [`cf3ffdc`](https://github.com/apache/spark/commit/cf3ffdc0a828aeb417e307b67bbf6e6ae4aaa685).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27799: [SPARK-31046][SQL]
Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594997110
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27799: [SPARK-31046][SQL] Make
more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594891159
**[Test build #119343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119343/testReport)** for PR 27799 at commit [`cf3ffdc`](https://github.com/apache/spark/commit/cf3ffdc0a828aeb417e307b67bbf6e6ae4aaa685).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27799:
[SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594997113
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119343/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27799: [SPARK-31046][SQL]
Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594892093
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24080/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27799:
[SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594997110
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27799:
[SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594891159
**[Test build #119343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119343/testReport)** for PR 27799 at commit [`cf3ffdc`](https://github.com/apache/spark/commit/cf3ffdc0a828aeb417e307b67bbf6e6ae4aaa685).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JkSelf commented on issue #27799: [SPARK-31046][SQL] Make
more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
JkSelf commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-595029463
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27799: [SPARK-31046][SQL]
Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-595165281
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27799: [SPARK-31046][SQL]
Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594997113
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119343/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maryannxue commented on issue #27799: [SPARK-31046][SQL]
Make more efficient and clean up AQE update UI code
Posted by GitBox <gi...@apache.org>.
maryannxue commented on issue #27799: [SPARK-31046][SQL] Make more efficient and clean up AQE update UI code
URL: https://github.com/apache/spark/pull/27799#issuecomment-594890999
cc @cloud-fan @JkSelf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org