[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #16292: [Done] BilinearResize2D optimized

[GitBox <gi...@apache.org>]

wkcn commented on a change in pull request #16292: [Done] BilinearResize2D optimized
URL: https://github.com/apache/incubator-mxnet/pull/16292#discussion_r333833744
 
 

 ##########
 File path: src/operator/contrib/bilinear_resize-inl.cuh
 ##########
 @@ -60,19 +60,63 @@ static unsigned getNumThreads(int nElem, const bool smaller) {
   return smaller ? (MAX_BLOCK_SIZE >> 1) : MAX_BLOCK_SIZE;
 }
 
-// caffe_gpu_interp2_kernel overloading with Tensor<xpu, 3, DType>
+__device__ __forceinline__ size_t
+idx(const size_t nc,
+  const size_t height,
+  const size_t width,
+  const size_t y,
+  const size_t x) {
+  return (nc * height + y) * width + x;
+}
+
+template <typename Acctype>
+__host__ MSHADOW_XINLINE static Acctype cu_area_pixel_compute_scale(
 
 Review comment:
   We can remove `__host__`, since `#define MSHADOW_XINLINE MSHADOW_FORCE_INLINE __device__ __host__
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services