You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/05/29 22:33:37 UTC
[GitHub] [maven-surefire] elharo opened a new pull request, #653: update commons-io to 2.12.0
elharo opened a new pull request, #653:
URL: https://github.com/apache/maven-surefire/pull/653
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] elharo commented on pull request #653: update commons-io to 2.12.0
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #653:
URL: https://github.com/apache/maven-surefire/pull/653#issuecomment-1573693135
I suppose there's some dispute about what constitutes a "trivial change". Again, some reviewers tell me not to file issues for this sort of thing. Some tell me to file issues. There simply isn't consensus here. And if we require Jira issues for every dependency change, dependabot really doesn't work. :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #653: update commons-io to 2.12.0
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #653:
URL: https://github.com/apache/maven-surefire/pull/653#issuecomment-1572251802
why we not have an issue for it ... when we not need issue? - do we have such rules or agreements?
sorry for such questions 😄 - but I see that many PR are without jira issues, so I'm interesting in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] elharo commented on pull request #653: update commons-io to 2.12.0
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #653:
URL: https://github.com/apache/maven-surefire/pull/653#issuecomment-1573572674
FYI commit messages are the same. Different reviewers request different and sometimes contradictory commit conventions. There aren't any established project wide standards for this that anyone pays attention to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] michael-o merged pull request #653: update commons-io to 2.12.0
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o merged PR #653:
URL: https://github.com/apache/maven-surefire/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slachiewicz commented on pull request #653: update commons-io to 2.12.0
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #653:
URL: https://github.com/apache/maven-surefire/pull/653#issuecomment-1573591998
https://github.com/apache/maven-surefire/blob/master/.github/pull_request_template.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] elharo commented on pull request #653: update commons-io to 2.12.0
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #653:
URL: https://github.com/apache/maven-surefire/pull/653#issuecomment-1573569906
We honestly don't seem to have any consensus on filing issues for straightforward dependency upgrades like this one. I've been told by some reviewers on some PRs to file issues and on others by other reviewers not to file issues.
If we're going to use dependabot or renovatebot, requiring Jira issues mostly defeats the purpose.
Unless it resolves an active bug in the Maven project itself — not the dependency — my preference is not to file an issue. And if it does resolve a bug, the issue should focus on the bug, not the dependency upgrade. As a user I prefer to not have the release notes cluttered with dependency upgrades that have no visible effect on my work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org