You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/25 18:18:07 UTC
[GitHub] [solr] cpoerschke opened a new pull request #710: Add missing comma in TestCloudSearcherWarming's config requests' JSON.
cpoerschke opened a new pull request #710:
URL: https://github.com/apache/solr/pull/710
(No JIRA ticket or solr/CHANGES.txt entry needed here I think.)
It seems that a
```
{
- 'add-listener' : { ... }
+ 'add-listener' : { ... },
'add-listener' : { ... }
}
```
change is appropriate for clear, well-formed JSON. But clearly it also works without the comma, and I have a strange sense of deja-vu about something like this elsewhere before, relaxed JSON parsing or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #710: Add missing comma in TestCloudSearcherWarming's config requests' JSON.
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #710:
URL: https://github.com/apache/solr/pull/710#issuecomment-1051086183
@andywebb1975 and/or @epugh - perhaps you may be interested in this in connection with https://github.com/apache/lucene-solr/pull/2643 changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke merged pull request #710: Add missing comma in TestCloudSearcherWarming's config requests' JSON.
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #710:
URL: https://github.com/apache/solr/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #710: Add missing comma in TestCloudSearcherWarming's config requests' JSON.
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #710:
URL: https://github.com/apache/solr/pull/710#issuecomment-1064418839
> Also surprised why the ConfigRequest does not throw an exception in the first place?
I chalked it up to Noggit being very lenient and allowing it through
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #710: Add missing comma in TestCloudSearcherWarming's config requests' JSON.
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #710:
URL: https://github.com/apache/solr/pull/710#issuecomment-1064416329
Also surprised why the ConfigRequest does not throw an exception in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #710: Add missing comma in TestCloudSearcherWarming's config requests' JSON.
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #710:
URL: https://github.com/apache/solr/pull/710#issuecomment-1064472801
Yes, it's https://github.com/apache/solr/blob/main/solr/solrj/src/java/org/noggit/JSONParser.java#L74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org